 17b8a2d6cd
			
		
	
	17b8a2d6cd
	
	
	
		
			
			If you run "config --blob" outside of a repository, then we eventually try to resolve the blob name and hit a BUG(). Let's catch this earlier and provide a useful message. Note that we could also catch this much lower in the stack, in git_config_from_blob_ref(). That might cover other callsites, too, but it's unclear whether those ones would actually be bugs or not. So let's leave the low-level functions to assume the caller knows what it's doing (and BUG() if it turns out it doesn't). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			81 lines
		
	
	
		
			2.0 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			81 lines
		
	
	
		
			2.0 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
| #!/bin/sh
 | |
| 
 | |
| test_description='support for reading config from a blob'
 | |
| . ./test-lib.sh
 | |
| 
 | |
| test_expect_success 'create config blob' '
 | |
| 	cat >config <<-\EOF &&
 | |
| 	[some]
 | |
| 		value = 1
 | |
| 	EOF
 | |
| 	git add config &&
 | |
| 	git commit -m foo
 | |
| '
 | |
| 
 | |
| test_expect_success 'list config blob contents' '
 | |
| 	echo some.value=1 >expect &&
 | |
| 	git config --blob=HEAD:config --list >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'fetch value from blob' '
 | |
| 	echo true >expect &&
 | |
| 	git config --blob=HEAD:config --bool some.value >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'reading non-existing value from blob is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:config non.existing
 | |
| '
 | |
| 
 | |
| test_expect_success 'reading from blob and file is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:config --system --list
 | |
| '
 | |
| 
 | |
| test_expect_success 'reading from missing ref is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:doesnotexist --list
 | |
| '
 | |
| 
 | |
| test_expect_success 'reading from non-blob is an error' '
 | |
| 	test_must_fail git config --blob=HEAD --list
 | |
| '
 | |
| 
 | |
| test_expect_success 'setting a value in a blob is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:config some.value foo
 | |
| '
 | |
| 
 | |
| test_expect_success 'deleting a value in a blob is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:config --unset some.value
 | |
| '
 | |
| 
 | |
| test_expect_success 'editing a blob is an error' '
 | |
| 	test_must_fail git config --blob=HEAD:config --edit
 | |
| '
 | |
| 
 | |
| test_expect_success 'parse errors in blobs are properly attributed' '
 | |
| 	cat >config <<-\EOF &&
 | |
| 	[some]
 | |
| 		value = "
 | |
| 	EOF
 | |
| 	git add config &&
 | |
| 	git commit -m broken &&
 | |
| 
 | |
| 	test_must_fail git config --blob=HEAD:config some.value 2>err &&
 | |
| 	test_i18ngrep "HEAD:config" err
 | |
| '
 | |
| 
 | |
| test_expect_success 'can parse blob ending with CR' '
 | |
| 	printf "[some]key = value\\r" >config &&
 | |
| 	git add config &&
 | |
| 	git commit -m CR &&
 | |
| 	echo value >expect &&
 | |
| 	git config --blob=HEAD:config some.key >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'config --blob outside of a repository is an error' '
 | |
| 	test_must_fail nongit git config --blob=foo --list
 | |
| '
 | |
| 
 | |
| test_done
 |