Move the tests for "-f <file>" where "<file>" contains a NUL byte pattern into their own file. I added most of these tests in966be95549("grep: add tests to fix blind spots with \0 patterns", 2017-05-20). Whether a regex engine supports matching binary content is very different from whether it matches binary patterns. Since2f8952250a("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) we've required REG_STARTEND of our regex engines so we can match binary content, but only the PCRE v2 engine can sensibly match binary patterns. Since9eceddeec6("Use kwset in grep", 2011-08-21) we've been punting patterns containing NUL-byte and considering them fixed, except in cases where "--ignore-case" is provided and they're non-ASCII, see5c1ebcca4d("grep/icase: avoid kwsset on literal non-ascii strings", 2016-06-25). Subsequent commits will change this behavior. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			149 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			149 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
 | 
						|
test_description='git grep in binary files'
 | 
						|
 | 
						|
. ./test-lib.sh
 | 
						|
 | 
						|
test_expect_success 'setup' "
 | 
						|
	echo 'binaryQfileQm[*]cQ*æQð' | q_to_nul >a &&
 | 
						|
	git add a &&
 | 
						|
	git commit -m.
 | 
						|
"
 | 
						|
 | 
						|
test_expect_success 'git grep ina a' '
 | 
						|
	echo Binary file a matches >expect &&
 | 
						|
	git grep ina a >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -ah ina a' '
 | 
						|
	git grep -ah ina a >actual &&
 | 
						|
	test_cmp a actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -I ina a' '
 | 
						|
	test_must_fail git grep -I ina a >actual &&
 | 
						|
	test_must_be_empty actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -c ina a' '
 | 
						|
	echo a:1 >expect &&
 | 
						|
	git grep -c ina a >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -l ina a' '
 | 
						|
	echo a >expect &&
 | 
						|
	git grep -l ina a >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -L bar a' '
 | 
						|
	echo a >expect &&
 | 
						|
	git grep -L bar a >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -q ina a' '
 | 
						|
	git grep -q ina a >actual &&
 | 
						|
	test_must_be_empty actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -F ile a' '
 | 
						|
	git grep -F ile a
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git grep -Fi iLE a' '
 | 
						|
	git grep -Fi iLE a
 | 
						|
'
 | 
						|
 | 
						|
# This test actually passes on platforms where regexec() supports the
 | 
						|
# flag REG_STARTEND.
 | 
						|
test_expect_success 'git grep ile a' '
 | 
						|
	git grep ile a
 | 
						|
'
 | 
						|
 | 
						|
test_expect_failure 'git grep .fi a' '
 | 
						|
	git grep .fi a
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep respects binary diff attribute' '
 | 
						|
	echo text >t &&
 | 
						|
	git add t &&
 | 
						|
	echo t:text >expect &&
 | 
						|
	git grep text t >actual &&
 | 
						|
	test_cmp expect actual &&
 | 
						|
	echo "t -diff" >.gitattributes &&
 | 
						|
	echo "Binary file t matches" >expect &&
 | 
						|
	git grep text t >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep --cached respects binary diff attribute' '
 | 
						|
	git grep --cached text t >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep --cached respects binary diff attribute (2)' '
 | 
						|
	git add .gitattributes &&
 | 
						|
	rm .gitattributes &&
 | 
						|
	git grep --cached text t >actual &&
 | 
						|
	test_when_finished "git rm --cached .gitattributes" &&
 | 
						|
	test_when_finished "git checkout .gitattributes" &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep revision respects binary diff attribute' '
 | 
						|
	git commit -m new &&
 | 
						|
	echo "Binary file HEAD:t matches" >expect &&
 | 
						|
	git grep text HEAD -- t >actual &&
 | 
						|
	test_when_finished "git reset HEAD^" &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep respects not-binary diff attribute' '
 | 
						|
	echo binQary | q_to_nul >b &&
 | 
						|
	git add b &&
 | 
						|
	echo "Binary file b matches" >expect &&
 | 
						|
	git grep bin b >actual &&
 | 
						|
	test_cmp expect actual &&
 | 
						|
	echo "b diff" >.gitattributes &&
 | 
						|
	echo "b:binQary" >expect &&
 | 
						|
	git grep bin b >actual.raw &&
 | 
						|
	nul_to_q <actual.raw >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
cat >nul_to_q_textconv <<'EOF'
 | 
						|
#!/bin/sh
 | 
						|
"$PERL_PATH" -pe 'y/\000/Q/' < "$1"
 | 
						|
EOF
 | 
						|
chmod +x nul_to_q_textconv
 | 
						|
 | 
						|
test_expect_success 'setup textconv filters' '
 | 
						|
	echo a diff=foo >.gitattributes &&
 | 
						|
	git config diff.foo.textconv "\"$(pwd)\""/nul_to_q_textconv
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep does not honor textconv' '
 | 
						|
	test_must_fail git grep Qfile
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep --textconv honors textconv' '
 | 
						|
	echo "a:binaryQfileQm[*]cQ*æQð" >expect &&
 | 
						|
	git grep --textconv Qfile >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep --no-textconv does not honor textconv' '
 | 
						|
	test_must_fail git grep --no-textconv Qfile
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'grep --textconv blob honors textconv' '
 | 
						|
	echo "HEAD:a:binaryQfileQm[*]cQ*æQð" >expect &&
 | 
						|
	git grep --textconv Qfile HEAD:a >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_done
 |