 3ffefb54c0
			
		
	
	3ffefb54c0
	
	
	
		
			
			While strbufs are pretty common throughout our code, it is more flexible for functions to take a pointer/len pair than a strbuf. It's easy to turn a strbuf into such a pair (by dereferencing its members), but less easy to go the other way (you can strbuf_attach, but that has implications about memory ownership). This patch teaches commit_tree (and its associated callers and sub-functions) to take such a pair for the commit message rather than a strbuf. This makes passing the buffer around slightly more verbose, but means we can get rid of some dangerous strbuf_attach calls in the next patch. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			38 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef NOTES_UTILS_H
 | |
| #define NOTES_UTILS_H
 | |
| 
 | |
| #include "notes.h"
 | |
| 
 | |
| /*
 | |
|  * Create new notes commit from the given notes tree
 | |
|  *
 | |
|  * Properties of the created commit:
 | |
|  * - tree: the result of converting t to a tree object with write_notes_tree().
 | |
|  * - parents: the given parents OR (if NULL) the commit referenced by t->ref.
 | |
|  * - author/committer: the default determined by commit_tree().
 | |
|  * - commit message: msg
 | |
|  *
 | |
|  * The resulting commit SHA1 is stored in result_sha1.
 | |
|  */
 | |
| void create_notes_commit(struct notes_tree *t, struct commit_list *parents,
 | |
| 			 const char *msg, size_t msg_len, unsigned char *result_sha1);
 | |
| 
 | |
| void commit_notes(struct notes_tree *t, const char *msg);
 | |
| 
 | |
| struct notes_rewrite_cfg {
 | |
| 	struct notes_tree **trees;
 | |
| 	const char *cmd;
 | |
| 	int enabled;
 | |
| 	combine_notes_fn combine;
 | |
| 	struct string_list *refs;
 | |
| 	int refs_from_env;
 | |
| 	int mode_from_env;
 | |
| };
 | |
| 
 | |
| struct notes_rewrite_cfg *init_copy_notes_for_rewrite(const char *cmd);
 | |
| int copy_note_for_rewrite(struct notes_rewrite_cfg *c,
 | |
| 			  const unsigned char *from_obj, const unsigned char *to_obj);
 | |
| void finish_copy_notes_for_rewrite(struct notes_rewrite_cfg *c, const char *msg);
 | |
| 
 | |
| #endif
 |