2bafb3d702
Before comparing with the expect file, we used to call function "make_user_friendly_and_stable_output" to filter out trailing spaces in output. Ævar recommends using pattern "s/Z$//" to prepare expect file, and then compare it with raw output. Since we have fixed the issue of occasionally missing the clear-to-eol suffix when displaying sideband #2 messages, it is safe and stable to test against raw output. Suggested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
134 lines
4.4 KiB
Bash
134 lines
4.4 KiB
Bash
test_expect_success "setup proc-receive hook and disable push-options ($PROTOCOL)" '
|
|
git -C "$upstream" config receive.advertisePushOptions false &&
|
|
write_script "$upstream/hooks/proc-receive" <<-EOF
|
|
printf >&2 "# proc-receive hook\n"
|
|
test-tool proc-receive -v \
|
|
-r "ok refs/for/main/topic"
|
|
EOF
|
|
'
|
|
|
|
# Refs of upstream : main(A)
|
|
# Refs of workbench: main(A) tags/v123
|
|
# git push -o ... : refs/for/main/topic
|
|
test_expect_success "proc-receive: not support push options ($PROTOCOL)" '
|
|
test_must_fail git -C workbench push \
|
|
-o issue=123 \
|
|
-o reviewer=user1 \
|
|
origin \
|
|
HEAD:refs/for/main/topic \
|
|
>out-$test_count 2>&1 &&
|
|
make_user_friendly_and_stable_output <out-$test_count >actual &&
|
|
test_i18ngrep "fatal: the receiving end does not support push options" \
|
|
actual &&
|
|
|
|
test_cmp_refs -C "$upstream" <<-EOF
|
|
<COMMIT-A> refs/heads/main
|
|
EOF
|
|
'
|
|
|
|
test_expect_success "enable push options ($PROTOCOL)" '
|
|
git -C "$upstream" config receive.advertisePushOptions true
|
|
'
|
|
|
|
test_expect_success "setup version=0 for proc-receive hook ($PROTOCOL)" '
|
|
write_script "$upstream/hooks/proc-receive" <<-EOF
|
|
printf >&2 "# proc-receive hook\n"
|
|
test-tool proc-receive -v \
|
|
--version 0 \
|
|
-r "ok refs/for/main/topic"
|
|
EOF
|
|
'
|
|
|
|
# Refs of upstream : main(A)
|
|
# Refs of workbench: main(A) tags/v123
|
|
# git push -o ... : next(A) refs/for/main/topic
|
|
test_expect_success "proc-receive: ignore push-options for version 0 ($PROTOCOL)" '
|
|
git -C workbench push \
|
|
--atomic \
|
|
-o issue=123 \
|
|
-o reviewer=user1 \
|
|
origin \
|
|
HEAD:refs/heads/next \
|
|
HEAD:refs/for/main/topic \
|
|
>out 2>&1 &&
|
|
make_user_friendly_and_stable_output <out >actual &&
|
|
format_and_save_expect <<-EOF &&
|
|
> remote: # pre-receive hook Z
|
|
> remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/heads/next Z
|
|
> remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> remote: # proc-receive hook Z
|
|
> remote: proc-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> remote: proc-receive> ok refs/for/main/topic Z
|
|
> remote: # post-receive hook Z
|
|
> remote: post-receive< <ZERO-OID> <COMMIT-A> refs/heads/next Z
|
|
> remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> To <URL/of/upstream.git>
|
|
> * [new branch] HEAD -> next
|
|
> * [new reference] HEAD -> refs/for/main/topic
|
|
EOF
|
|
test_cmp expect actual &&
|
|
|
|
test_cmp_refs -C "$upstream" <<-EOF
|
|
<COMMIT-A> refs/heads/main
|
|
<COMMIT-A> refs/heads/next
|
|
EOF
|
|
'
|
|
|
|
test_expect_success "restore proc-receive hook ($PROTOCOL)" '
|
|
write_script "$upstream/hooks/proc-receive" <<-EOF
|
|
printf >&2 "# proc-receive hook\n"
|
|
test-tool proc-receive -v \
|
|
-r "ok refs/for/main/topic"
|
|
EOF
|
|
'
|
|
|
|
# Refs of upstream : main(A) next(A)
|
|
# Refs of workbench: main(A) tags/v123
|
|
test_expect_success "cleanup ($PROTOCOL)" '
|
|
git -C "$upstream" update-ref -d refs/heads/next
|
|
'
|
|
|
|
# Refs of upstream : main(A)
|
|
# Refs of workbench: main(A) tags/v123
|
|
# git push -o ... : next(A) refs/for/main/topic
|
|
test_expect_success "proc-receive: push with options ($PROTOCOL)" '
|
|
git -C workbench push \
|
|
--atomic \
|
|
-o issue=123 \
|
|
-o reviewer=user1 \
|
|
origin \
|
|
HEAD:refs/heads/next \
|
|
HEAD:refs/for/main/topic \
|
|
>out 2>&1 &&
|
|
make_user_friendly_and_stable_output <out >actual &&
|
|
format_and_save_expect <<-EOF &&
|
|
> remote: # pre-receive hook Z
|
|
> remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/heads/next Z
|
|
> remote: pre-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> remote: # proc-receive hook Z
|
|
> remote: proc-receive: atomic push_options Z
|
|
> remote: proc-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> remote: proc-receive< issue=123 Z
|
|
> remote: proc-receive< reviewer=user1 Z
|
|
> remote: proc-receive> ok refs/for/main/topic Z
|
|
> remote: # post-receive hook Z
|
|
> remote: post-receive< <ZERO-OID> <COMMIT-A> refs/heads/next Z
|
|
> remote: post-receive< <ZERO-OID> <COMMIT-A> refs/for/main/topic Z
|
|
> To <URL/of/upstream.git>
|
|
> * [new branch] HEAD -> next
|
|
> * [new reference] HEAD -> refs/for/main/topic
|
|
EOF
|
|
test_cmp expect actual &&
|
|
|
|
test_cmp_refs -C "$upstream" <<-EOF
|
|
<COMMIT-A> refs/heads/main
|
|
<COMMIT-A> refs/heads/next
|
|
EOF
|
|
'
|
|
|
|
# Refs of upstream : main(A) next(A)
|
|
# Refs of workbench: main(A) tags/v123
|
|
test_expect_success "cleanup ($PROTOCOL)" '
|
|
git -C "$upstream" update-ref -d refs/heads/next
|
|
'
|