A lot of shell scripts contained stuff starting with while case "$#" in 0) break ;; esac and similar. I consider breaking out of the condition instead of the body od the loop ugly, and the implied "true" value of the non-matching case is not really obvious to humans at first glance. It happens not to be obvious to some BSD shells, either, but that's because they are not POSIX-compliant. In most cases, this has been replaced by a straight condition using "test". "case" has the advantage of being faster than "test" on vintage shells where "test" is not a builtin. Since none of them is likely to run the git scripts, anyway, the added readability should be worth the change. A few loops have had their termination condition expressed differently. Signed-off-by: David Kastrup <dak@gnu.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			38 lines
		
	
	
		
			594 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
		
			594 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
#
 | 
						|
# Copyright (c) 2006, Shawn O. Pearce
 | 
						|
#
 | 
						|
# Cleanup unreachable files and optimize the repository.
 | 
						|
 | 
						|
USAGE='[--prune]'
 | 
						|
SUBDIRECTORY_OK=Yes
 | 
						|
. git-sh-setup
 | 
						|
 | 
						|
no_prune=:
 | 
						|
while test $# != 0
 | 
						|
do
 | 
						|
	case "$1" in
 | 
						|
	--prune)
 | 
						|
		no_prune=
 | 
						|
		;;
 | 
						|
	--)
 | 
						|
		usage
 | 
						|
		;;
 | 
						|
	esac
 | 
						|
	shift
 | 
						|
done
 | 
						|
 | 
						|
case "$(git config --get gc.packrefs)" in
 | 
						|
notbare|"")
 | 
						|
	test $(is_bare_repository) = true || pack_refs=true;;
 | 
						|
*)
 | 
						|
	pack_refs=$(git config --bool --get gc.packrefs)
 | 
						|
esac
 | 
						|
 | 
						|
test "true" != "$pack_refs" ||
 | 
						|
git pack-refs --prune &&
 | 
						|
git reflog expire --all &&
 | 
						|
git-repack -a -d -l &&
 | 
						|
$no_prune git prune &&
 | 
						|
git rerere gc || exit
 |