The top-level &&-chain checker built into t/test-lib.sh causes tests to
magically exit with code 117 if the &&-chain is broken. However, it has
the shortcoming that the magic does not work within `{...}` groups,
`(...)` subshells, `$(...)` substitutions, or within bodies of compound
statements, such as `if`, `for`, `while`, `case`, etc. `chainlint.sed`
partly fills in the gap by catching broken &&-chains in `(...)`
subshells, but bugs can still lurk behind broken &&-chains in the other
cases.
Fix broken &&-chains in `{...}` groups in order to reduce the number of
possible lurking bugs.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			51 lines
		
	
	
		
			903 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			51 lines
		
	
	
		
			903 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
 | 
						|
test_description='basic tests for the oidtree implementation'
 | 
						|
TEST_PASSES_SANITIZE_LEAK=true
 | 
						|
. ./test-lib.sh
 | 
						|
 | 
						|
maxhexsz=$(test_oid hexsz)
 | 
						|
echoid () {
 | 
						|
	prefix="${1:+$1 }"
 | 
						|
	shift
 | 
						|
	while test $# -gt 0
 | 
						|
	do
 | 
						|
		shortoid="$1"
 | 
						|
		shift
 | 
						|
		difference=$(($maxhexsz - ${#shortoid}))
 | 
						|
		printf "%s%s%0${difference}d\\n" "$prefix" "$shortoid" "0"
 | 
						|
	done
 | 
						|
}
 | 
						|
 | 
						|
test_expect_success 'oidtree insert and contains' '
 | 
						|
	cat >expect <<-\EOF &&
 | 
						|
		0
 | 
						|
		0
 | 
						|
		0
 | 
						|
		1
 | 
						|
		1
 | 
						|
		0
 | 
						|
	EOF
 | 
						|
	{
 | 
						|
		echoid insert 444 1 2 3 4 5 a b c d e &&
 | 
						|
		echoid contains 44 441 440 444 4440 4444 &&
 | 
						|
		echo clear
 | 
						|
	} | test-tool oidtree >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'oidtree each' '
 | 
						|
	echoid "" 123 321 321 >expect &&
 | 
						|
	{
 | 
						|
		echoid insert f 9 8 123 321 a b c d e &&
 | 
						|
		echo each 12300 &&
 | 
						|
		echo each 3211 &&
 | 
						|
		echo each 3210 &&
 | 
						|
		echo each 32100 &&
 | 
						|
		echo clear
 | 
						|
	} | test-tool oidtree >actual &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_done
 |