d2c470f9bc
Here, GCC warns about every use of the INIT_PROC_ADDR macro, for example:
In file included from compat/mingw.c:8:
compat/mingw.c: In function 'mingw_strftime':
compat/win32/lazyload.h:38:12: warning: assignment to
'size_t (*)(char *, size_t, const char *, const struct tm *)'
{aka 'long long unsigned int (*)(char *, long long unsigned int,
const char *, const struct tm *)'} from incompatible pointer type
'FARPROC' {aka 'long long int (*)()'} [-Wincompatible-pointer-types]
38 | (function = get_proc_addr(&proc_addr_##function))
| ^
compat/mingw.c:1014:6: note: in expansion of macro 'INIT_PROC_ADDR'
1014 | if (INIT_PROC_ADDR(strftime))
| ^~~~~~~~~~~~~~
(message wrapped for convenience). Insert a cast to keep the compiler
happy. A cast is fine in these cases because they are generic function
pointer values that have been looked up in a DLL.
Helped-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
59 lines
1.6 KiB
C
59 lines
1.6 KiB
C
#ifndef LAZYLOAD_H
|
|
#define LAZYLOAD_H
|
|
|
|
/*
|
|
* A pair of macros to simplify loading of DLL functions. Example:
|
|
*
|
|
* DECLARE_PROC_ADDR(kernel32.dll, BOOL, CreateHardLinkW,
|
|
* LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
|
|
*
|
|
* if (!INIT_PROC_ADDR(CreateHardLinkW))
|
|
* return error("Could not find CreateHardLinkW() function";
|
|
*
|
|
* if (!CreateHardLinkW(source, target, NULL))
|
|
* return error("could not create hardlink from %S to %S",
|
|
* source, target);
|
|
*/
|
|
|
|
struct proc_addr {
|
|
const char *const dll;
|
|
const char *const function;
|
|
FARPROC pfunction;
|
|
unsigned initialized : 1;
|
|
};
|
|
|
|
/* Declares a function to be loaded dynamically from a DLL. */
|
|
#define DECLARE_PROC_ADDR(dll, rettype, function, ...) \
|
|
static struct proc_addr proc_addr_##function = \
|
|
{ #dll, #function, NULL, 0 }; \
|
|
typedef rettype (WINAPI *proc_type_##function)(__VA_ARGS__); \
|
|
static proc_type_##function function
|
|
|
|
/*
|
|
* Loads a function from a DLL (once-only).
|
|
* Returns non-NULL function pointer on success.
|
|
* Returns NULL + errno == ENOSYS on failure.
|
|
* This function is not thread-safe.
|
|
*/
|
|
#define INIT_PROC_ADDR(function) \
|
|
(function = (proc_type_##function)get_proc_addr(&proc_addr_##function))
|
|
|
|
static inline FARPROC get_proc_addr(struct proc_addr *proc)
|
|
{
|
|
/* only do this once */
|
|
if (!proc->initialized) {
|
|
HANDLE hnd;
|
|
proc->initialized = 1;
|
|
hnd = LoadLibraryExA(proc->dll, NULL,
|
|
LOAD_LIBRARY_SEARCH_SYSTEM32);
|
|
if (hnd)
|
|
proc->pfunction = GetProcAddress(hnd, proc->function);
|
|
}
|
|
/* set ENOSYS if DLL or function was not found */
|
|
if (!proc->pfunction)
|
|
errno = ENOSYS;
|
|
return proc->pfunction;
|
|
}
|
|
|
|
#endif
|