The function switched between two operating modes depending on the NULL-ness of its two parameters, as a hacky way to share small part of implementation, sacrificing cleanliness of the API. Implement "fmt_output_subject()" function that takes a subject string and gives the name for the output file, and on top of it, implement "fmt_output_commit()" function that takes a commit and gives the name for the output file. Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			28 lines
		
	
	
		
			927 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			28 lines
		
	
	
		
			927 B
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef LOG_TREE_H
 | 
						|
#define LOG_TREE_H
 | 
						|
 | 
						|
#include "revision.h"
 | 
						|
 | 
						|
struct log_info {
 | 
						|
	struct commit *commit, *parent;
 | 
						|
};
 | 
						|
 | 
						|
int parse_decorate_color_config(const char *var, const int ofs, const char *value);
 | 
						|
void init_log_tree_opt(struct rev_info *);
 | 
						|
int log_tree_diff_flush(struct rev_info *);
 | 
						|
int log_tree_commit(struct rev_info *, struct commit *);
 | 
						|
int log_tree_opt_parse(struct rev_info *, const char **, int);
 | 
						|
void show_log(struct rev_info *opt);
 | 
						|
void show_decorations(struct rev_info *opt, struct commit *commit);
 | 
						|
void log_write_email_headers(struct rev_info *opt, struct commit *commit,
 | 
						|
			     const char **subject_p,
 | 
						|
			     const char **extra_headers_p,
 | 
						|
			     int *need_8bit_cte_p);
 | 
						|
void load_ref_decorations(int flags);
 | 
						|
 | 
						|
#define FORMAT_PATCH_NAME_MAX 64
 | 
						|
void fmt_output_commit(struct strbuf *, struct commit *, struct rev_info *);
 | 
						|
void fmt_output_subject(struct strbuf *, const char *subject, struct rev_info *);
 | 
						|
 | 
						|
#endif
 |