Whenbf1a11f0a1(sideband: highlight keywords in remote sideband output, 2018-08-07) was introduced, it was carefully considered which strings would be highlighted. However59a255aef0(sideband: do not read beyond the end of input, 2018-08-18) brought in a regression that the original did not test for. A line containing only the keyword and nothing else ("SUCCESS") should still be colored. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			104 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			104 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
 | 
						|
test_description='remote messages are colorized on the client'
 | 
						|
 | 
						|
. ./test-lib.sh
 | 
						|
 | 
						|
test_expect_success 'setup' '
 | 
						|
	mkdir .git/hooks &&
 | 
						|
	write_script .git/hooks/update <<-\EOF &&
 | 
						|
	echo error: error
 | 
						|
	echo ERROR: also highlighted
 | 
						|
	echo hint: hint
 | 
						|
	echo hinting: not highlighted
 | 
						|
	echo success: success
 | 
						|
	echo warning: warning
 | 
						|
	echo prefixerror: error
 | 
						|
	echo " " "error: leading space"
 | 
						|
	echo "    "
 | 
						|
	echo Err
 | 
						|
	echo SUCCESS
 | 
						|
	exit 0
 | 
						|
	EOF
 | 
						|
	echo 1 >file &&
 | 
						|
	git add file &&
 | 
						|
	git commit -m 1 &&
 | 
						|
	git clone . child &&
 | 
						|
	(
 | 
						|
		cd child &&
 | 
						|
		test_commit message2 file content2
 | 
						|
	)
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'keywords' '
 | 
						|
	git --git-dir child/.git -c color.remote=always push -f origin HEAD:refs/heads/keywords 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<BOLD;RED>error<RESET>: error" decoded &&
 | 
						|
	grep "<YELLOW>hint<RESET>:" decoded &&
 | 
						|
	grep "<BOLD;GREEN>success<RESET>:" decoded &&
 | 
						|
	grep "<BOLD;GREEN>SUCCESS<RESET>" decoded &&
 | 
						|
	grep "<BOLD;YELLOW>warning<RESET>:" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'whole words at line start' '
 | 
						|
	git --git-dir child/.git -c color.remote=always push -f origin HEAD:refs/heads/whole-words 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<YELLOW>hint<RESET>:" decoded &&
 | 
						|
	grep "hinting: not highlighted" decoded &&
 | 
						|
	grep "prefixerror: error" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'short line' '
 | 
						|
	git -C child -c color.remote=always push -f origin HEAD:short-line 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "remote: Err" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'case-insensitive' '
 | 
						|
	git --git-dir child/.git -c color.remote=always push -f origin HEAD:refs/heads/case-insensitive 2>output &&
 | 
						|
	cat output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<BOLD;RED>error<RESET>: error" decoded &&
 | 
						|
	grep "<BOLD;RED>ERROR<RESET>: also highlighted" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'leading space' '
 | 
						|
	git --git-dir child/.git -c color.remote=always push -f origin HEAD:refs/heads/leading-space 2>output &&        cat output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "  <BOLD;RED>error<RESET>: leading space" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'spaces only' '
 | 
						|
	git -C child -c color.remote=always push -f origin HEAD:only-space 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "remote:     " decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'no coloring for redirected output' '
 | 
						|
	git --git-dir child/.git push -f origin HEAD:refs/heads/redirected-output 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "error: error" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'push with customized color' '
 | 
						|
	git --git-dir child/.git -c color.remote=always -c color.remote.error=blue push -f origin HEAD:refs/heads/customized-color 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<BLUE>error<RESET>:" decoded &&
 | 
						|
	grep "<BOLD;GREEN>success<RESET>:" decoded
 | 
						|
'
 | 
						|
 | 
						|
 | 
						|
test_expect_success 'error in customized color' '
 | 
						|
	git --git-dir child/.git -c color.remote=always -c color.remote.error=i-am-not-a-color push -f origin HEAD:refs/heads/error-customized-color 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<BOLD;GREEN>success<RESET>:" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'fallback to color.ui' '
 | 
						|
	git --git-dir child/.git -c color.ui=always push -f origin HEAD:refs/heads/fallback-color-ui 2>output &&
 | 
						|
	test_decode_color <output >decoded &&
 | 
						|
	grep "<BOLD;RED>error<RESET>: error" decoded
 | 
						|
'
 | 
						|
 | 
						|
test_done
 |