 db4eca1fea
			
		
	
	db4eca1fea
	
	
	
		
			
			"git clone --config" uses the following incantation to add an item to a config file, instead of replacing an existing value: git_config_set_multivar_gently(key, value, "^$", 0) As long as no existing value matches the regex ^$, that works as intended and adds to the config. When a value is empty, though, it replaces the existing value. Noticed while trying to set credential.helper during a clone to use a specific helper without inheriting from ~/.gitconfig and /etc/gitconfig. That is, I ran git clone -c credential.helper= \ -c credential.helper=myhelper \ https://example.com/repo intending to produce the configuration [credential] helper = helper = myhelper Without this patch, the 'helper =' line is not included and the credential helper from /etc/gitconfig gets used. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			69 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			69 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
| #!/bin/sh
 | |
| 
 | |
| test_description='tests for git clone -c key=value'
 | |
| . ./test-lib.sh
 | |
| 
 | |
| test_expect_success 'clone -c sets config in cloned repo' '
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.foo=bar . child &&
 | |
| 	echo bar >expect &&
 | |
| 	git --git-dir=child/.git config core.foo >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'clone -c can set multi-keys' '
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.foo=bar -c core.foo=baz . child &&
 | |
| 	{ echo bar; echo baz; } >expect &&
 | |
| 	git --git-dir=child/.git config --get-all core.foo >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'clone -c can set multi-keys, including some empty' '
 | |
| 	rm -rf child &&
 | |
| 	git clone -c credential.helper= -c credential.helper=hi . child &&
 | |
| 	printf "%s\n" "" hi >expect &&
 | |
| 	git --git-dir=child/.git config --get-all credential.helper >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'clone -c without a value is boolean true' '
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.foo . child &&
 | |
| 	echo true >expect &&
 | |
| 	git --git-dir=child/.git config --bool core.foo >actual &&
 | |
| 	test_cmp expect actual
 | |
| '
 | |
| 
 | |
| test_expect_success 'clone -c config is available during clone' '
 | |
| 	echo content >file &&
 | |
| 	git add file &&
 | |
| 	git commit -m one &&
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.autocrlf . child &&
 | |
| 	printf "content\\r\\n" >expect &&
 | |
| 	test_cmp expect child/file
 | |
| '
 | |
| 
 | |
| # Tests for the hidden file attribute on windows
 | |
| is_hidden () {
 | |
| 	# Use the output of `attrib`, ignore the absolute path
 | |
| 	case "$(attrib "$1")" in *H*?:*) return 0;; esac
 | |
| 	return 1
 | |
| }
 | |
| 
 | |
| test_expect_success MINGW 'clone -c core.hideDotFiles' '
 | |
| 	test_commit attributes .gitattributes "" &&
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.hideDotFiles=false . child &&
 | |
| 	! is_hidden child/.gitattributes &&
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.hideDotFiles=dotGitOnly . child &&
 | |
| 	! is_hidden child/.gitattributes &&
 | |
| 	rm -rf child &&
 | |
| 	git clone -c core.hideDotFiles=true . child &&
 | |
| 	is_hidden child/.gitattributes
 | |
| '
 | |
| 
 | |
| test_done
 |