6789275d37
They are equivalents and the former still exists, so as long as the
only change this commit makes are to rewrite test_i18ngrep to
test_grep, there won't be any new bug, even if there still are
callers of test_i18ngrep remaining in the tree, or when merged to
other topics that add new uses of test_i18ngrep.
This patch was produced more or less with
git grep -l -e 'test_i18ngrep ' 't/t[0-9][0-9][0-9][0-9]-*.sh' |
xargs perl -p -i -e 's/test_i18ngrep /test_grep /'
and a good way to sanity check the result yourself is to run the
above in a checkout of c4603c1c (test framework: further deprecate
test_i18ngrep, 2023-10-31) and compare the resulting working tree
contents with the result of applying this patch to the same commit.
You'll see that test_i18ngrep in a few t/lib-*.sh files corrected,
in addition to the manual reproduction.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
166 lines
3.7 KiB
Bash
Executable File
166 lines
3.7 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='commit --pathspec-from-file'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_tick
|
|
|
|
test_expect_success setup '
|
|
test_commit file0 &&
|
|
git tag checkpoint &&
|
|
|
|
echo A >fileA.t &&
|
|
echo B >fileB.t &&
|
|
echo C >fileC.t &&
|
|
echo D >fileD.t &&
|
|
git add fileA.t fileB.t fileC.t fileD.t
|
|
'
|
|
|
|
restore_checkpoint () {
|
|
git reset --soft checkpoint
|
|
}
|
|
|
|
verify_expect () {
|
|
git diff-tree --no-commit-id --name-status -r HEAD >actual &&
|
|
test_cmp expect actual
|
|
}
|
|
|
|
test_expect_success '--pathspec-from-file from stdin' '
|
|
restore_checkpoint &&
|
|
|
|
echo fileA.t | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success '--pathspec-from-file from file' '
|
|
restore_checkpoint &&
|
|
|
|
echo fileA.t >list &&
|
|
git commit --pathspec-from-file=list -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'NUL delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\0fileB.t\0" | git commit --pathspec-from-file=- --pathspec-file-nul -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'LF delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\nfileB.t\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'no trailing delimiter' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\nfileB.t" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'CRLF delimiters' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileA.t\r\nfileB.t\r\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
A fileB.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'quotes' '
|
|
restore_checkpoint &&
|
|
|
|
cat >list <<-\EOF &&
|
|
"file\101.t"
|
|
EOF
|
|
|
|
git commit --pathspec-from-file=list -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileA.t
|
|
EOF
|
|
verify_expect expect
|
|
'
|
|
|
|
test_expect_success 'quotes not compatible with --pathspec-file-nul' '
|
|
restore_checkpoint &&
|
|
|
|
cat >list <<-\EOF &&
|
|
"file\101.t"
|
|
EOF
|
|
|
|
test_must_fail git commit --pathspec-from-file=list --pathspec-file-nul -m "Commit"
|
|
'
|
|
|
|
test_expect_success 'only touches what was listed' '
|
|
restore_checkpoint &&
|
|
|
|
printf "fileB.t\nfileC.t\n" | git commit --pathspec-from-file=- -m "Commit" &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
A fileB.t
|
|
A fileC.t
|
|
EOF
|
|
verify_expect
|
|
'
|
|
|
|
test_expect_success 'error conditions' '
|
|
restore_checkpoint &&
|
|
echo fileA.t >list &&
|
|
>empty_list &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=list --interactive -m "Commit" 2>err &&
|
|
test_grep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=list --patch -m "Commit" 2>err &&
|
|
test_grep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=list --all -m "Commit" 2>err &&
|
|
test_grep -e "options .--pathspec-from-file. and .-a. cannot be used together" err &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=list -m "Commit" -- fileA.t 2>err &&
|
|
test_grep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
|
|
|
|
test_must_fail git commit --pathspec-file-nul -m "Commit" 2>err &&
|
|
test_grep -e "the option .--pathspec-file-nul. requires .--pathspec-from-file." err &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=empty_list --include -m "Commit" 2>err &&
|
|
test_grep -e "No paths with --include/--only does not make sense." err &&
|
|
|
|
test_must_fail git commit --pathspec-from-file=empty_list --only -m "Commit" 2>err &&
|
|
test_grep -e "No paths with --include/--only does not make sense." err
|
|
'
|
|
|
|
test_done
|