0af861e0c8
We long ago switched most code to using object_id structs instead of bare "unsigned char *" hashes. This gives us more type safety from the compiler, and generally makes it easier to understand what we expect in each parameter. But the dumb-http code has lagged behind. And indeed, the whole "walker" subsystem interface has the same problem, though http-walker is the only user left. So let's update the walker interface to pass object_id structs (which we already have anyway at all call sites!), and likewise use those within the http-walker methods that it calls. This cleans up the dumb-http code a bit, but will also let us fix a few more commonly used helper functions. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Taylor Blau <me@ttaylorr.com>
39 lines
1.1 KiB
C
39 lines
1.1 KiB
C
#ifndef WALKER_H
|
|
#define WALKER_H
|
|
|
|
#include "remote.h"
|
|
|
|
struct walker {
|
|
void *data;
|
|
int (*fetch_ref)(struct walker *, struct ref *ref);
|
|
void (*prefetch)(struct walker *, const struct object_id *oid);
|
|
int (*fetch)(struct walker *, const struct object_id *oid);
|
|
void (*cleanup)(struct walker *);
|
|
int get_verbosely;
|
|
int get_progress;
|
|
int get_recover;
|
|
|
|
int corrupt_object_found;
|
|
};
|
|
|
|
/* Report what we got under get_verbosely */
|
|
__attribute__((format (printf, 2, 3)))
|
|
void walker_say(struct walker *walker, const char *fmt, ...);
|
|
|
|
/* Load pull targets from stdin */
|
|
int walker_targets_stdin(char ***target, const char ***write_ref);
|
|
|
|
/* Free up loaded targets */
|
|
void walker_targets_free(int targets, char **target, const char **write_ref);
|
|
|
|
/* If write_ref is set, the ref filename to write the target value to. */
|
|
/* If write_ref_log_details is set, additional text will appear in the ref log. */
|
|
int walker_fetch(struct walker *impl, int targets, char **target,
|
|
const char **write_ref, const char *write_ref_log_details);
|
|
|
|
void walker_free(struct walker *walker);
|
|
|
|
struct walker *get_http_walker(const char *url);
|
|
|
|
#endif /* WALKER_H */
|