wgengine/tsdns: truncate Map.PrettyDiffFrom string at 1KB

Hello's were painful.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2021-03-10 07:31:11 -08:00
parent cc99059fc2
commit 0430c2dd12
2 changed files with 33 additions and 0 deletions

View File

@ -5,6 +5,8 @@
package tsdns
import (
"fmt"
"strings"
"testing"
"inet.af/netaddr"
@ -135,4 +137,20 @@ func TestPrettyDiffFrom(t *testing.T) {
}
})
}
t.Run("truncated", func(t *testing.T) {
small := NewMap(nil, nil)
m := map[string]netaddr.IP{}
for i := 0; i < 5000; i++ {
m[fmt.Sprintf("host%d.ipn.dev.", i)] = netaddr.IPv4(100, 64, 1, 1)
}
veryBig := NewMap(m, nil)
diff := veryBig.PrettyDiffFrom(small)
if len(diff) > 3<<10 {
t.Errorf("pretty diff too large: %d bytes", len(diff))
}
if !strings.Contains(diff, "truncated") {
t.Errorf("big diff not truncated")
}
})
}