all: use tstest.Replace more

Signed-off-by: Maisem Ali <maisem@tailscale.com>
2023-03-04 12:04:55 -08:00
parent 57a44846ae
commit 1a30b2d73f
12 changed files with 35 additions and 58 deletions
--- a/wgengine/filter/filter_test.go
+++ b/wgengine/filter/filter_test.go
@ -419,14 +419,8 @@ func TestOmitDropLogging(t *testing.T) {
 }

 func TestLoggingPrivacy(t *testing.T) {
-	oldDrop := dropBucket
-	oldAccept := acceptBucket
-	dropBucket = rate.NewLimiter(2^32, 2^32)
-	acceptBucket = dropBucket
-	defer func() {
-		dropBucket = oldDrop
-		acceptBucket = oldAccept
-	}()
+	tstest.Replace(t, &dropBucket, rate.NewLimiter(2^32, 2^32))
+	tstest.Replace(t, &acceptBucket, dropBucket)

 	var (
 		logged     bool