mirrors/tailscale
1
0
Fork 0
Code Issues Pull Requests Projects Wiki Activity

derp, netcheck: make tests listen on localhost only

Browse Source 
avoid macOS firewall pop-ups
This commit is contained in:
Brad Fitzpatrick 2020-03-30 11:29:08 -07:00
parent 5362e952e1
commit 1df3c8d02a
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
derp/derp_test.go
View File

@ -42,7 +42,7 @@ func TestSendRecv(t *testing.T) {
clientKeys = append(clientKeys, priv.Public()) clientKeys = append(clientKeys, priv.Public())
} }
ln, err := net.Listen("tcp", ":0") ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }

4
netcheck/netcheck_test.go
View File

@ -9,7 +9,6 @@
"fmt" "fmt"
"net" "net"
"reflect" "reflect"
"strings"
"testing" "testing"
"time" "time"
@ -71,14 +70,13 @@ func TestBasic(t *testing.T) {
} }
func TestWorksWhenUDPBlocked(t *testing.T) { func TestWorksWhenUDPBlocked(t *testing.T) {
blackhole, err := net.ListenPacket("udp4", ":0") blackhole, err := net.ListenPacket("udp4", "127.0.0.1:0")
if err != nil { if err != nil {
t.Fatalf("failed to open blackhole STUN listener: %v", err) t.Fatalf("failed to open blackhole STUN listener: %v", err)
} }
defer blackhole.Close() defer blackhole.Close()
stunAddr := blackhole.LocalAddr().String() stunAddr := blackhole.LocalAddr().String()
stunAddr = strings.Replace(stunAddr, "0.0.0.0:", "127.0.0.1:", 1)
c := &Client{ c := &Client{
DERP: derpmap.NewTestWorld(stunAddr), DERP: derpmap.NewTestWorld(stunAddr),