From 2f27319baf71681e221904d3a3ffe1badedc8e2e Mon Sep 17 00:00:00 2001 From: Jordan Whited Date: Wed, 14 Aug 2024 11:36:48 -0700 Subject: [PATCH] wgengine/netstack: disable gVisor TCP GRO for Linux (#13138) A SIGSEGV was observed around packet merging logic in gVisor's GRO package. Updates tailscale/corp#22353 Signed-off-by: Jordan Whited --- wgengine/netstack/netstack.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wgengine/netstack/netstack.go b/wgengine/netstack/netstack.go index 2bac50a9f..3c8a357d9 100644 --- a/wgengine/netstack/netstack.go +++ b/wgengine/netstack/netstack.go @@ -326,8 +326,9 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi } var linkEP *linkEndpoint if runtime.GOOS == "linux" { - // TODO(jwhited): add Windows support https://github.com/tailscale/corp/issues/21874 - linkEP = newLinkEndpoint(512, uint32(tstun.DefaultTUNMTU()), "", enableGRO) + // TODO(jwhited): add Windows GSO support https://github.com/tailscale/corp/issues/21874 + // TODO(jwhited): exercise enableGRO in relation to https://github.com/tailscale/corp/issues/22353 + linkEP = newLinkEndpoint(512, uint32(tstun.DefaultTUNMTU()), "", disableGRO) linkEP.SupportedGSOKind = stack.HostGSOSupported } else { linkEP = newLinkEndpoint(512, uint32(tstun.DefaultTUNMTU()), "", disableGRO)