From 7c3f480767166a08dd4c95b69d16b0e85734573d Mon Sep 17 00:00:00 2001 From: Mihai Parparita Date: Wed, 27 Jul 2022 15:46:13 -0700 Subject: [PATCH] cmd/tsconnect: lint during build step Ensures that TypeScript checks pass before we deploy. Signed-off-by: Mihai Parparita --- cmd/tsconnect/build.go | 5 +++++ cmd/tsconnect/common.go | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/cmd/tsconnect/build.go b/cmd/tsconnect/build.go index a47979acc..570f3038a 100644 --- a/cmd/tsconnect/build.go +++ b/cmd/tsconnect/build.go @@ -28,6 +28,11 @@ func runBuild() { log.Fatalf("Cannot setup: %v", err) } + log.Printf("Linting...\n") + if err := runYarn("lint"); err != nil { + log.Fatalf("Linting failed: %v", err) + } + if err := cleanDist(); err != nil { log.Fatalf("Cannot clean %s: %v", *distDir, err) } diff --git a/cmd/tsconnect/common.go b/cmd/tsconnect/common.go index 2f15d230e..efe35460f 100644 --- a/cmd/tsconnect/common.go +++ b/cmd/tsconnect/common.go @@ -104,7 +104,11 @@ func buildWasm(dev bool) error { // installJSDeps installs the JavaScript dependencies specified by package.json func installJSDeps() error { log.Printf("Installing JS deps...\n") - cmd := exec.Command(*yarnPath) + return runYarn() +} + +func runYarn(args ...string) error { + cmd := exec.Command(*yarnPath, args...) cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr return cmd.Run()