control/controlclient: de-pointer Status.PersistView, document more

Updates #cleanup
Updates #1909

Change-Id: I31d91e120e3b299508de2136021eab3b34131a44
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2023-08-30 11:35:43 -07:00
committed by Brad Fitzpatrick
parent 7053e19562
commit f5bfdefa00
4 changed files with 22 additions and 13 deletions

View File

@ -21,7 +21,6 @@ import (
"tailscale.com/types/logger"
"tailscale.com/types/netmap"
"tailscale.com/types/persist"
"tailscale.com/types/ptr"
"tailscale.com/types/structs"
)
@ -644,9 +643,9 @@ func (c *Auto) sendStatus(who string, err error, url string, nm *netmap.NetworkM
c.logf("[v1] sendStatus: %s: %v", who, state)
var p *persist.PersistView
var p persist.PersistView
if nm != nil && loggedIn && synced {
p = ptr.To(c.direct.GetPersist())
p = c.direct.GetPersist()
} else {
// don't send netmap status, as it's misleading when we're
// not logged in.