Commit Graph

22715 Commits

Author SHA1 Message Date
5122d43d87 Merge pull request #19596 from mmorel-35/usetesting/tests/robustness
tests/robustness: address Go 1.24 usetesting issues
2025-03-14 17:30:04 +00:00
d100da7431 Merge pull request #19595 from mmorel-35/usetesting/tests/framework
tests/framework: address Go 1.24 usetesting issues
2025-03-14 17:29:51 +00:00
e31514dc84 Merge pull request #19593 from mmorel-35/usetesting/tests/e2e
tests/e2e: address Go 1.24 usetesting issues
2025-03-14 17:29:38 +00:00
630fb0a43b Merge pull request #19592 from mmorel-35/usetesting/tests/common
tests/common:  address Go 1.24 usetesting issues
2025-03-14 17:29:23 +00:00
c571cff478 Merge pull request #19591 from mmorel-35/usetesting/etcdutl
etcdutl: address Go 1.24 usetesting issues
2025-03-14 17:29:12 +00:00
82a3e6fe27 Merge pull request #19603 from ahrtr/changelog_etcdctl_20250314
Update 3.5 changelog to cover the member promotion command not suppor…
2025-03-14 14:38:57 +00:00
c2701197fb Update 3.5 changelog to cover the member promotion command not support json output issue
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-03-14 13:03:06 +00:00
8b4c2cc11e Merge pull request #19590 from mmorel-35/usetesting/server
server: address Go 1.24 usetesting issues
2025-03-14 09:24:35 +00:00
ce5620760b Merge pull request #19589 from mmorel-35/usetesting/client
client: address Go 1.24 usetesting issues
2025-03-14 09:24:07 +00:00
a5bef1b837 Merge pull request #19572 from ahrtr/new_approver_20250311
Nominate @fuweid as a new approver
2025-03-13 22:07:02 +00:00
d87cb88d57 tests/common: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 22:03:50 +01:00
175f18ee8e tests/framework: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 20:18:20 +01:00
b92073d1cb tests/e2e: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 20:16:52 +01:00
2717859dab tests/robustness: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 20:11:57 +01:00
6c69b1a709 etcdutl: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 19:59:09 +01:00
dc6db52c34 server: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 19:53:48 +01:00
3e207cfda0 client: address Go 1.24 usetesting issues
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-03-13 19:48:50 +01:00
05d57531e4 Merge pull request #19576 from ivanvc/client-pkg-go-1.24-usetesting-errors
client/pkg: address Go 1.24 usetesting issues
2025-03-13 20:20:02 +13:00
6984bbe731 Merge pull request #19575 from ivanvc/pkg-go-1.24-usetesting-errors
pkg: address Go 1.24 usetesting issues
2025-03-13 20:19:42 +13:00
f4c40b7fd0 Merge pull request #19425 from Zanda256/tooling_markdown_lint
Tooling for markdown linting
2025-03-13 09:47:09 +13:00
3f20b705fe client/pkg: address Go 1.24 usetesting issues
Use the test package's provided Chdir function. Therefore, it's not
required to evaluate an error (it doesn't return one) or change
directories at the end.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-11 17:35:54 -07:00
619d949b8d pkg: address Go 1.24 usetesting issues
Replace Contexts with the one provided by the test package.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-11 16:50:13 -07:00
4804c48d8b Nominate @fuweid as a new approver
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-03-11 09:57:02 +00:00
ffb6ff9acf Merge pull request #19564 from etcd-io/dependabot/github_actions/github/codeql-action-3.28.11
build(deps): bump github/codeql-action from 3.28.10 to 3.28.11
2025-03-11 17:40:30 +13:00
6635bf633e build(deps): bump github/codeql-action from 3.28.10 to 3.28.11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.10 to 3.28.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](b56ba49b26...6bb031afdd)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-10 18:02:53 +00:00
3c916bb258 Merge pull request #19554 from rsafonseca/fix_proxy_bug
fix: grpcproxy can get stuck in and endless loop causing high cpu usage
2025-03-10 10:17:08 +01:00
dc09500b8f Merge pull request #19555 from ivanvc/remove-experimental-max-learners
server: remove ExperimentalMaxLearners
2025-03-10 09:16:24 +00:00
06edd83d28 server: remove ExperimentalMaxLearners
ExperimentalMaxLearners was introduced in v3.6, so there's no need to
worry about deprecating, it can be migrated straight into a FeatureGate.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-07 22:22:43 -08:00
f4e1d0e1bc Add marckdowncli linting script, config file and makefile target to enable markdown linting
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
2025-03-07 16:35:02 +03:00
d0b8863552 Merge pull request #19552 from serathius/robustness-client-put-count
Use clientPutCount instead of persistedPutCount as not all client requests are persisted
2025-03-07 14:03:38 +01:00
85d90d9dd9 fix: grpcproxy can get stuck in and endless loop causing high cpu usage
Signed-off-by: Rafael da Fonseca <rafael.fonseca@wildlifestudios.com>
2025-03-07 11:11:59 +00:00
890990c32c Use clientPutCount instead of persistedPutCount as not all client requests are persisted
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2025-03-07 10:52:54 +01:00
22b5b78530 Merge pull request #19383 from joshuazh-x/issue-19303
fix: skip duplicated puts when calculating put return time
2025-03-07 10:35:15 +01:00
9f1709e015 Merge pull request #19546 from ivanvc/use-go-mod-instead-of-go-list-in-release-scripts
scripts/release: Use `go mod` instead of `go list`
2025-03-06 11:59:08 +01:00
8e4de789e5 Merge pull request #19440 from ivanvc/bump-go-to-1.24.0
Bump go toolchain to 1.24.1
2025-03-06 07:51:04 +00:00
7e66d3a9fc scripts/release: Use go mod instead of go list
Replace `go list -m` with `go mod edit -json`, as the latter can return
the same information. This will be helpful when the project migrates to
using a Go workspace, as it will return the current module defined in
go.mod rather than all the modules from the current directory (using a
workspace, the top-level go.mod will return all the child modules from
the repository).

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 22:50:15 -08:00
930bf4c41b Merge pull request #19543 from ivanvc/update-changelog-v3.5.19-v3.6.0-rc.2
Update changelog with v3.5.19 v3.6.0-rc.2 release dates
2025-03-06 19:18:07 +13:00
5dea90cc95 CHANGELOG: Set v3.6.0-rc.2 release date
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 11:57:09 -08:00
b88df6ea53 CHANGELOG: Set v3.5.19 release date
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 11:56:54 -08:00
f0a1ec501b Merge pull request #19538 from fuweid/deflaky-TestCompactionHash-in-integration
deflakey: TestCompactionHash in integration
2025-03-05 18:56:07 +00:00
7456d52dab Disable usetesting linter
The linter fails with several warnings from new Go 1.24 functions. Due
to the amount of changed lines, it will be better to address them in
several follow-up pull requests.

> 146 files changed, 1157 insertions(+), 1212 deletions(-)

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 09:06:14 -08:00
31650ab0c8 server: Fix TestLogRotation error message in Go 1.24
The embedded structure is now also part of the log message. The failure
from the tests is the following:

--- FAIL: TestLogRotation (0.00s)
    --- FAIL: TestLogRotation/invalid_logger_config (0.00s)
        config_test.go:868: test "invalid logger config", expected
        error: invalid log rotation config: json: cannot unmarshal
               bool into Go struct field logRotationConfig.maxsize
               of type int,
        got: invalid log rotation config: json: cannot unmarshal
             bool into Go struct field logRotationConfig.Logger.maxsize
             of type int
FAIL

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 09:05:57 -08:00
028773129a Bump go toolchain to 1.24.1
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-03-05 09:00:05 -08:00
b58e9f522f deflakey: TestCompactionHash in integration
We should use WithCompactPhysical to wait for compaction to finish,
because 50ms sleep can't guarantee compaction is done.

Based on the log, the defragment is finished before compaction, which is
not expected. This patch is to make sure compaction should be finished
before assertation.

```
=========================== defragment ==============
    logger.go:146: 2025-02-27T07:57:18.652Z	INFO	m0	finished defragment	{"member": "m0"}
=====================================================

    logger.go:146: 2025-02-27T07:57:18.652Z	INFO	m0	grpc service status changed	{"member": "m0", "service": "", "status": "SERVING"}
    logger.go:146: 2025-02-27T07:57:18.653Z	INFO	grpc	[[core] [Channel #1457]Channel Connectivity change to SHUTDOWN]
    logger.go:146: 2025-02-27T07:57:18.653Z	INFO	grpc	[[core] [Channel #1457]Closing the name resolver]
    logger.go:146: 2025-02-27T07:57:18.653Z	INFO	grpc	[[core] [Channel #1457]ccBalancerWrapper: closing]
    logger.go:146: 2025-02-27T07:57:18.653Z	INFO	grpc	[[core] [Channel #1457 SubChannel #1458]Subchannel Connectivity change to SHUTDOWN]
    logger.go:146: 2025-02-27T07:57:18.653Z	INFO	grpc	[[core] [Channel #1457 SubChannel #1458]Subchannel deleted]
    logger.go:146: 2025-02-27T07:57:18.654Z	INFO	grpc	[[transport] [client-transport 0xc00237bd48] Closing: rpc error: code = Canceled desc = grpc: the client connection is closing]
    logger.go:146: 2025-02-27T07:57:18.654Z	INFO	grpc	[[transport] [client-transport 0xc00237bd48] loopyWriter exiting with error: rpc error: code = Canceled desc = grpc: the client connection is closing]
    logger.go:146: 2025-02-27T07:57:18.654Z	INFO	grpc	[[transport] [server-transport 0xc0006bb520] Closing: EOF]
    logger.go:146: 2025-02-27T07:57:18.654Z	INFO	grpc	[[core] [Channel #1457]Channel deleted]
    logger.go:146: 2025-02-27T07:57:18.654Z	INFO	grpc	[[transport] [server-transport 0xc0006bb520] loopyWriter exiting with error: transport closed by client]
    hash.go:82:
        	Error Trace:	/home/prow/go/src/github.com/etcd-io/etcd/server/storage/mvcc/testutil/hash.go:82
        	            				/home/prow/go/src/github.com/etcd-io/etcd/server/storage/mvcc/testutil/hash.go:44
        	Error:      	Not equal:
        	            	expected: testutil.KeyValueHash{Hash:0x94694091, CompactRevision:1278, Revision:2507}
        	            	actual  : testutil.KeyValueHash{Hash:0x58af47dc, CompactRevision:2488, Revision:2507}

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (testutil.KeyValueHash) {
        	            	- Hash: (uint32) 2489925777,
        	            	- CompactRevision: (int64) 1278,
        	            	+ Hash: (uint32) 1487882204,
        	            	+ CompactRevision: (int64) 2488,
        	            	  Revision: (int64) 2507
        	Test:       	TestCompactionHash
        	Messages:   	hashes do not match on rev 2488
    cluster.go:1423: ========= Cluster termination started =====================
    logger.go:146: 2025-02-27T07:57:18.655Z	INFO	grpc	[[core] [Channel #1377]Channel Connectivity change to SHUTDOWN]
    logger.go:146: 2025-02-27T07:57:18.655Z	INFO	grpc	[[core] [Channel #1377]Closing the name resolver]
    logger.go:146: 2025-02-27T07:57:18.655Z	INFO	grpc	[[core] [Channel #1377]ccBalancerWrapper: closing]
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	grpc	[[core] [Channel #1377 SubChannel #1378]Subchannel Connectivity change to SHUTDOWN]
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	grpc	[[core] [Channel #1377 SubChannel #1378]Subchannel deleted]
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	grpc	[[transport] [client-transport 0xc0025f2248] Closing: rpc error: code = Canceled desc = grpc: the client connection is closing]
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	grpc	[[transport] [client-transport 0xc0025f2248] loopyWriter exiting with error: rpc error: code = Canceled desc = grpc: the client connection is closing]
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	grpc	[[transport] [server-transport 0xc000b56ea0] Closing: EOF]

=========================== compaction ==============
    logger.go:146: 2025-02-27T07:57:18.656Z	INFO	m0	finished scheduled compaction	{"member": "m0", "compact-revision": 2488, "took": "129.590742ms", "hash": 2489925777, "current-db-size-bytes": 40960, "current-db-size": "41 kB", "current-db-size-in-use-bytes": 40960, "current-db-size-in-use": "41 kB"}
=====================================================
```

Fixes: #19497

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-03-05 11:56:36 -05:00
316991e8d1 Merge pull request #19523 from ArkaSaha30/deps_mgmt_5_2_25
[2025-02-03] Manual Dependency Bump
2025-03-05 23:32:30 +13:00
31ff0a9cc8 dependency: bump github.com/rogpeppe/go-internal from v1.13.1 to v1.14.1
This commit will bump inderect dependency(of github.com/golangci/golangci-lint)  github.com/rogpeppe/go-internal from v1.13.1 to v1.14.1

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2025-03-05 13:10:52 +05:30
b9ceba8c9f dependency: bump golang.org/x/net from v0.35.0 to v0.36.0
This commit will bump dependency golang.org/x/net from v0.35.0 to v0.36.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2025-03-05 13:10:52 +05:30
5da0dc0091 dependency: bump github.com/golangci/golangci-lint from 1.64.5 to 1.64.6
This commit will bump dependency github.com/golangci/golangci-lint from 1.64.5 to 1.64.6

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2025-03-05 13:10:52 +05:30
04710062d1 dependency: bump github.com/prometheus/client_golang from 1.20.5 to 1.21.0
This commit will bump dependency github.com/prometheus/client_golang from 1.20.5 to 1.21.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2025-03-05 13:10:52 +05:30
7c866508ef dependency: bump github.com/klauspost/compress from 1.17.9 to 1.18.0
This commit will bump dependency github.com/klauspost/compress from 1.17.9 to 1.18.0
which is an indirect dependency of the direct dependency: github.com/prometheus/client_golang

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2025-03-05 13:10:52 +05:30