Commit Graph

22602 Commits

Author SHA1 Message Date
Benjamin Wang
d52bd901b4
Merge pull request #19461 from fuweid/fix-downgrade-issue
deflake: TestDowngradeCancellationAfterDowngrading1InClusterOf3
2025-02-22 15:37:46 +00:00
Wei Fu
2de17bd396 deflake: TestDowngradeCancellationAfterDowngrading1InClusterOf3
Fixes: 65159a2b96 (*: Update cases related to Downgrade)

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-22 08:22:17 -05:00
Benjamin Wang
ac7d3e9335
Merge pull request #19451 from fuweid/add-downgrade-status
*: support DowngradeInfo field in maintenence.Status API
2025-02-21 21:02:20 +00:00
Wei Fu
65159a2b96 *: Update cases related to Downgrade
1. Update DowngradeUpgradeMembersByID

If it's downgrading process, the desire version of cluster should be
target one.
If it's upgrading process, the desire version of cluster should be
determined by mininum binary version of members.

2. Remove AssertProcessLogs from DowngradeEnable

The log message "The server is ready to downgrade" appears only when the storage
version monitor detects a mismatch between the cluster and storage versions.

If traffic is insufficient to trigger a commit or if an auto-commit occurs right
after reading the storage version, the monitor may fail to update it, leading
to errors like:

```bash
"msg":"failed to update storage version","cluster-version":"3.6.0",
"error":"cannot detect storage schema version: missing confstate information"
```

Given this, we should remove the AssertProcessLogs statement.

Similar to #19313

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-21 13:45:41 -05:00
Wei Fu
091b6ed718 etcdctl: support downgrade info in endpoint command
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-21 11:50:25 -05:00
Benjamin Wang
49f34c9751
Merge pull request #19340 from aladesawe/server-apply-unexported-return
Rename `applierMembership` to `ApplierMembership` to fix the `unexported-return` lint error
2025-02-20 09:28:54 +00:00
Benjamin Wang
82c371a471
Merge pull request #19341 from aladesawe/server-storage-recorder-unexported-return
Rename `storageRecorder` to `StorageRecorder` to fix `unexported-return` lint error
2025-02-20 09:28:27 +00:00
Benjamin Wang
a29b97ab8c
Merge pull request #19450 from jmhbnz/main
Simplify release permissions process
2025-02-20 08:39:32 +00:00
Wei Fu
8575de3bab v3rpc: add DowngradeInfo in status API
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-19 17:18:08 -05:00
Wei Fu
9d57554c4c proto: add DowngradeProcessInfo in statusResponse
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-19 17:17:59 -05:00
James Blair
cf6f4fbb94
Simplify release permissions process.
Signed-off-by: James Blair <mail@jamesblair.net>
2025-02-20 08:16:53 +13:00
Benjamin Wang
ef65923cf7
Merge pull request #19431 from joshjms/main
Update CHANGELOG for version bump to go 1.23.6
2025-02-19 08:01:24 +00:00
Benjamin Wang
deb9178089
Merge pull request #19342 from aladesawe/server-alarm-unexported-return
Move interface `AlarmBackend` from `server/etcdserver/api/v3alarm` to `server/storage/schema` to fix the `unexported-return` lint error
2025-02-18 17:58:03 +00:00
Marek Siarkowicz
1e3710a90f
Merge pull request #19432 from 1911860538/feat/server-lease
perf: use RLock in Demoted method for read-only access to expiry
2025-02-18 09:14:20 +01:00
huangzw
e10f01edfe perf: use RLock in Demoted method for read-only access to expiry
Signed-off-by: huangzw <huangzw@2345.com>
2025-02-17 16:09:34 +08:00
joshjms
d86775c276 changelog: update entries for v3.4.36 and v3.5.19 to reflect 1.23.6 update
Signed-off-by: joshjms <joshjms1607@gmail.com>
2025-02-17 14:44:14 +08:00
adeyemi
e37cdc66c4 Rename applierMembership struct to fix unexported-return
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2025-02-16 21:35:18 -08:00
adeyemi
6f27da2aee Move AlarmBackend interface to fix unexported-return
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2025-02-16 21:22:53 -08:00
adeyemi
c0c9f7c344 Create an StorageRecorder interface to fix unexported-return
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2025-02-16 21:02:19 -08:00
Benjamin Wang
eb7607bd8b
Merge pull request #19421 from ivanvc/remove-contrib-mixin-github-workflow
github/workflows: remove contrib workflow
2025-02-16 16:05:43 +00:00
Marek Siarkowicz
c86bb08fa9
Merge pull request #19422 from ivanvc/remove-fuzzing-github-workflow
github/workflows: remove fuzzing workflow.
2025-02-16 12:06:09 +01:00
Ivan Valdes
c733872ea3
github/workflows: remove fuzzing workflow.
This job is already running in the Prow infrastructure.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-14 14:13:23 -08:00
Ivan Valdes
0bbc42a3de
github/workflows: remove contrib workflow
This job is already running in the Prow infrastructure.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-14 14:10:02 -08:00
Benjamin Wang
14cf6694e9
Merge pull request #19418 from ivanvc/fix-release-script-prerelease-github-template-release
Fix release script prerelease GitHub template release
2025-02-14 19:20:32 +00:00
Ivan Valdes
5c9db9c840
scripts/release: fix typo in "flag"
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-14 09:23:08 -08:00
Ivan Valdes
b1e513cfe9
scripts/release: fix getting version minor for prereleases
The GitHub release templates had the wrong version minor when there's a
prerelease part in the version (i.e., v3.6.0-rc.0). It cut until the
last dot, leaving a wrong minor version (i.e., v3.6.0-rc).

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-14 09:23:06 -08:00
Ivan Valdes
8c52b414f3
CHANGELOG-3.6: Set v3.6.0-rc.0 release date
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-13 12:36:25 -08:00
Benjamin Wang
91762ccd4f
Merge pull request #19413 from henrybear327/feat/add_flag
Migrate --experimental-set-member-localaddr to using feature flag
2025-02-13 17:08:06 +00:00
Chun-Hung Tseng
5fa8c1f6b8 Migrate --experimental-set-member-localaddr to using feature flag
Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
2025-02-13 16:02:10 +00:00
Marek Siarkowicz
865ed4a0b6
Merge pull request #19412 from ahrtr/changelog_20250213
Add the fix of the performance regression due to uncertain compaction…
2025-02-13 13:31:30 +01:00
Benjamin Wang
fb2cdc31c7 Add the fix of the performance regression due to uncertain compaction sleep interval
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-13 11:03:09 +00:00
Benjamin Wang
3bd966d6b5
Merge pull request #19410 from ahrtr/compact_20250213
Fix a performance regression due to uncertain compaction sleep interval
2025-02-13 10:36:58 +00:00
Benjamin Wang
de10fd6565 Fix a peformance regression due to uncertain compaction sleep interval
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-13 09:40:04 +00:00
Benjamin Wang
075fb1058a
Merge pull request #19407 from ivanvc/changelog-3.6-19403-deprecation
CHANGELOG-3.6: Add note from #19404
2025-02-13 07:55:18 +00:00
Benjamin Wang
b77a28cbb5
Merge pull request #19408 from ivanvc/more-v3.6-deprecation-comments
Fix more v3.6 deprecation comments
2025-02-13 07:51:33 +00:00
Ivan Valdes
8af64f886c
CHANGELOG-3.6: Add note from #19404
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 17:06:16 -08:00
Ivan Valdes
9c30af2ff5
Standardize help deprecated messages
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:29:40 -08:00
Ivan Valdes
eea79ca9a5
Properly deprecate ExperimentalInitialCorruptCheck
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:14:34 -08:00
Ivan Valdes
fe81901c74
Properly deprecate ExperimentalStopGRPCServiceOnDefrag
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 16:03:07 -08:00
Ivan Valdes
e37615a483
Properly deprecate ExperimentalTxnModeWriteWithSharedBuffer
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 15:57:57 -08:00
Benjamin Wang
7073c4140f
Merge pull request #19403 from ivanvc/remove-server-deprecated-new-zap-core-logger-builder
server: Remove deprecated NewZapCoreLoggerBuilder
2025-02-12 21:22:52 +00:00
Ivan Valdes
8b99f8e025
server/embed: Remove deprecated NewZapCoreLoggerBuilder
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 11:20:50 -08:00
Benjamin Wang
dd6791c560
Merge pull request #19401 from ivanvc/fix-deprecation-notices
Fix v3.6 deprecation notices
2025-02-12 19:10:47 +00:00
Ivan Valdes
1f4b3cdf52
Fix deprecation comments in server/features
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 10:05:52 -08:00
Ivan Valdes
7ba8929e7b
Fix deprecation comments in server/embed
Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 10:05:03 -08:00
Ivan Valdes
95efe44ae0
Fix rpctypes.ErrClusterIdMismatch deprecation comment
It was pointing to ErrGRPCClusterIDMismatch rather than
ErrClusterIDMismatch.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2025-02-12 10:02:33 -08:00
Benjamin Wang
f30cbaac11
Merge pull request #19398 from ahrtr/downgrade_test_20250212
[test] Correct the expected version in downgrade test case
2025-02-12 15:56:47 +00:00
Benjamin Wang
57dc6f375a Correct the expected version in downgrade test case
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-12 11:02:48 +00:00
Marek Siarkowicz
c0e7e8c873
Merge pull request #19370 from shashwat010/visualize
Remove passing of anonymous visualize function
2025-02-12 10:45:14 +01:00
shashwat-jain
5414dbab4a Merge remote-tracking branch 'etcd/main' into visualize 2025-02-12 11:36:26 +05:30