Commit Graph

385 Commits

Author SHA1 Message Date
091b6ed718 etcdctl: support downgrade info in endpoint command
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-21 11:50:25 -05:00
10d7cea552 chore: enable early-return and superfluous-else from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Co-authored-by: Iván Valdés Castillo <iv@nvald.es>
2025-01-18 09:44:58 +01:00
3b8b0b48ec fix: use testify instead of t.Fatal or t.Error in etcdctl packages
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-12-13 22:06:41 +01:00
647f1621d6 fix: enable gosimple linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-12-03 07:32:22 +01:00
3ef69d2681 fix: enable gofumpt instead of gofmt linter in contrib, etcdctl and etcdutl
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-11-09 00:37:14 +01:00
ff632e45f8 fix: enable errorlint in etcdctl and etcdutl directories
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-31 08:00:36 +01:00
ed9f61df28 feat(etcdctl): add --max-send-bytes and --max-recv-bytes options
Signed-off-by: Direktor799 <priceclaptrap@hotmail.com>
2024-10-16 19:54:41 +08:00
b757772ebc Update endpointsFromCluster to reuse clientConfigFromCmd
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-10-15 14:06:16 +01:00
4957e5670e update epHealthCommandFunc to reuse clientConfigFromCmd
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-10-15 09:48:12 +01:00
33d7f2d53e fix: enable gofmt and whitespace linters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-11 07:03:18 +02:00
59cfd7a61d Merge pull request #18612 from Kamandlou/km-dev
update: `cobra.ExactValidArgs` method is deprecated
2024-09-24 10:05:29 +01:00
6767e1ff64 command: Use errors.Is for error equality check in ep_command.go
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-23 10:12:40 -07:00
063627e42f update: cobra.ExactValidArgs method is deprecated
Signed-off-by: Kamandlou <ahkamandlou@gmail.com>
2024-09-23 17:22:05 +03:30
16fb3f6527 Create util for etcdctl, move helper of cobra from main package to
etcdctl util, create normalizer of examples in util, add some more
examples, change indent of etcdctl from "\t" to "  "

Signed-off-by: ah8ad3 <ah8ad3@gmail.com>
2024-08-04 13:37:22 +03:30
07b35dd7e3 etcdctl: add support for filtering by {min,max} x {create,mod} x {revision}
Signed-off-by: Cristian Ferretti <jcferretti2020@gmail.com>
2024-07-02 12:48:00 -04:00
59864bc2cb rebase with latest main
Signed-off-by: Will Russell <will.russell.01@gmail.com>
2024-05-17 15:08:51 -04:00
dafadd13c1 all: don't convert byte slice to string when using verb %s
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-04-25 23:34:52 +08:00
f3daf5e041 all: make regexp.Regexp variables global when not using configuration methods
As the doc of regexp.Regex is saying:

"A Regexp is safe for concurrent use by multiple goroutines, except for configuration
methods, such as Regexp.Longest."

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-03-26 18:49:50 +08:00
fbda591866 fix some typos
Signed-off-by: thirdkeyword <fliterdashen@gmail.com>
2024-03-25 10:34:44 +08:00
aa97484166 *: enable goimports in verify-lint
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 21:14:09 +08:00
c0aa3b613b Use any instead of interface{}
Signed-off-by: chenyahui <cyhone@qq.com>
2023-09-17 17:41:58 +08:00
223a75b399 etcdctl/ctlv3/command: simplify code using fmt.Printf with '\n'
The current printing code is complicated. This PR simplifies the
code and reduces the function calls.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2023-07-17 19:37:15 +08:00
a9864d4edb etcdctl: update the description for flag '--rev'
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-06-02 15:53:08 +08:00
0c919dc212 use the more efficient strings.Builder
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-05-19 10:44:58 +08:00
91a5f01a4e Add detailed long description for etcdctl txn.
Include an example stdin usage and a link for full docs.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-17 11:38:56 +13:00
1f0d361848 clientv3: support serializable MemberList operation
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-25 07:23:39 +08:00
6f899a7b40 Merge pull request #15052 from ptabor/20221228-goimports-fix
./scripts/fix.sh: Takes care of goimports across the whole project.
2022-12-29 11:31:22 +01:00
9e1abbab6e Fix goimports in all existing files. Execution of ./scripts/fix.sh
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-12-29 09:41:31 +01:00
0c67e318d7 enhancement(ctlv3): display as learner when member add as learner
Signed-off-by: wafuwafu13 <mariobaske@i.softbank.jp>
2022-12-29 13:18:23 +09:00
8a75cfff67 Improve memberList output consistency
Signed-off-by: Unai Arrien <unaittxu@gmail.com>
2022-12-19 13:09:19 +01:00
9a7f9609d6 etcdctl: changed 'revision' to 'hash_revision' in hashkv table output
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-25 18:59:49 +08:00
48b8210044 etcdctl: display HashRevision for 127.0.0.1:2379, 1084519789 command
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-25 18:49:16 +08:00
c3b6cbdb73 all: goimports -w .
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
2022-11-17 19:07:04 +03:00
2c9c209eb6 all: Changing Printf and friends to Print if there is no formatting
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
2022-11-15 22:11:23 +03:00
74085136b3 etcdctl: connect to the same endpoint as the target to be maintained
The client may connect to a different endpint as the target to be
maintained. When auth is enabled, the target endpoint might haven't
finished applying the authentiation request, so it might reject the
corresponding maintenance request due to permission denied.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-03 04:55:27 +08:00
72cf0cc04a etcd: modify declaring empty slices
declare an empty slice to var s []int replace  s :=[]int{}, https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices

Signed-off-by: demoManito <1430482733@qq.com>
2022-09-16 14:41:14 +08:00
3fc16608f7 etcdctl: fix move-leader for multiple endpoints
Due to a duplicate call of clientConfigFromCmd, the move-leader command
would fail with "conflicting environment variable is shadowed by corresponding command-line flag".
Also in scenarios where no command-line flag was supplied.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-09-09 10:38:13 +02:00
ff6b85da83 Merge pull request #14340 from xakdwch/main
etcdctl: add --max-txn-ops flag to make-mirror command
2022-08-17 05:36:16 +08:00
7cc3f5f97e etcdctl: add --max-txn-ops flag to make-mirror command
--max-txn-ops flag allows users to define the maximum number of operations permitted in
a transaction during syncing updates.if unlimited syncing may fail when number of txn ops
exceeds the maximum number of server side.

Signed-off-by: xakdwch <xakdwch5@gmail.com>
2022-08-15 13:38:32 +08:00
5cae1a1c48 Print clusterID, memberID and leaseID in hexdecimal
ClusterID, memberID and leaseID are just identifies, so it doesn't
make sense to print them in decimal. Instead, we should always print
them in hexdecimal.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-16 07:21:13 +08:00
89637a4223 Tools/benchmark: migrate cheggaaa/pb.v1 to cheggaaa/pb/v3
etcdctl/ctlv3: migrate cheggaaa/pb.v1 to cheggaaa/pb/v3

This commit also changes the format of the progress bar, from using a
custom progress bar to the default provided by the library.

Old behaviour:

./benchmarkv1  put
 0 / 10000 B                                                   !   0.00%
 3987 / 10000 Boooooooooooooom                                 !  39.87%
 10000 / 10000 Boooooooooooooooooooooooooooooooooooooooooooo! 100.00% 1s

New behaviour:

./benchmark put
 6536 / 10000 [----------------------->________________] 65.36% 7053 p/s
10000 / 10000 [---------------------------------------] 100.00% 7581 p/s

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2022-06-20 15:47:23 +02:00
e1e3ed11e3 Doc: provide more clarify to the usage of check perf command
This PR describes the fact that different workloads in the `check perf` command
are different, and the results might vary.

Signed-off-by: Eduardo Patrocinio <epatro@gmail.com>
2022-06-17 13:13:58 -03:00
657a197bfa add range flag for delete in etcdctl 2022-05-17 11:17:42 +08:00
beeb44d4ee hide the revision field when it isn't populated 2022-05-13 19:40:57 +08:00
55f0c96fa0 tests: Migrate Txn tests to common functional test framework 2022-05-11 10:33:47 +05:30
63346bfead server: Use default logging configuration instead of zap production one
This fixes problem where logs json changes format of timestamp.
2022-04-01 10:23:42 +02:00
f978da4f4f move the newClientCfg into clientv3 package so as to be reused by both etcdctl and v3discovery 2022-03-24 06:18:25 +08:00
3254125e6c Merge pull request #13809 from kkkkun/cleanup-deprecated-commands
Removing deprecated commands in etcdctl & etcdutl
2022-03-23 11:21:01 -04:00
1649c9dfc2 Removing deprecated commands in etcdctl & etcdutl 2022-03-23 11:05:52 +08:00
3780435831 added unit test for newClientCfg 2022-03-22 19:07:40 +08:00