cad3fce1a0
fix: use testify instead of t.Fatal or t.Error in pkg package
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-02-02 16:30:18 +01:00
88b39386b4
Merge pull request #19152 from mmorel-35/revive/superfluous-else
...
chore: enable early-return and superfluous-else from revive
2025-01-19 08:49:14 +00:00
10d7cea552
chore: enable early-return and superfluous-else from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
Co-authored-by: Iván Valdés Castillo <iv@nvald.es >
2025-01-18 09:44:58 +01:00
dcbd309945
flags: optimise memory allocation
...
Signed-off-by: Artur Melanchyk <arturmelanchyk@imail.name >
2025-01-15 19:39:00 +01:00
0a71106a68
fix: use testify instead of t.Fatal or t.Error in pkg package (part 1)
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-12-11 07:57:37 +01:00
c2261efc06
Merge pull request #18774 from mmorel-35/golangci-lint/tenv
...
fix: enable tenv linter
2024-10-24 10:49:06 +02:00
048fd57df6
fix: enable tenv linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-24 07:52:17 +02:00
55de68d18c
Merge pull request #18722 from mmorel-35/api/errorlint
...
fix: enable errorlint in api, client and pkg
2024-10-20 09:16:30 +01:00
6165f60419
fix: enable expected-actual rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-17 09:17:59 +00:00
b281a3c4fa
fix: enable errorlint in api, client and pkg
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-13 19:43:20 +02:00
bd228cf6d1
migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-08-05 13:46:51 -07:00
4f78cc0810
pkg/flags: fix UniqueURLs'Set to remove duplicates in UniqueURLs'uss
...
From the name of func 'UniqueURLsFromFlag', we can tell that UniqueURLs'uss
should not have duplicates. The current implemention of UniqueURLs'Set
has a bug to make it unique.
Fixes : #16307 .
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2023-07-26 22:28:44 +08:00
855aa4f7a7
all: Use ReplaceAll instead of Replace with -1 pos
...
Signed-off-by: Sasha Melentyev <sasha@melentyev.io >
2022-11-15 00:06:09 +03:00
a9c3d56508
etcd: remove redundant type conversion
...
Signed-off-by: demoManito <1430482733@qq.com >
2022-09-20 11:26:02 +08:00
b2726c4da3
Merge pull request #12469 from trawler/client_listen_unix_socket
...
pkg/types: Support Unix sockets in NewURLS
2022-08-09 06:40:31 +08:00
8b6c8b4c96
add unit test for pkg/flags/Uint32FromFlag in uint32_test.go
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-07 04:52:28 +08:00
1a6fe4dbc6
update the comment for MaxConcurrentStreams to clearly state it's the max value for each client.
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-07 04:51:20 +08:00
d8347ec683
add & refine the uint32Value data type
...
The golang buildin package `flag` doesn't support `uint32` data
type, so we need to support it via the `flag.Var`.
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-06 03:43:46 +08:00
6220174687
support custom grpc.MaxConcurrentStreams
...
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.
The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.
```
https://github.com/etcd-io/etcd/pull/14081
```
Signed-off-by: nic-chen <chenjunxu6@gmail.com >
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-06 03:43:46 +08:00
804fddf921
tests: Use zaptest.NewLogger in tests
2022-04-04 13:03:15 +02:00
75747f24bc
Add unix socket test to TestNewURLsValue
2021-10-07 11:59:32 +02:00
d93b7c8cb1
pkg/types: Support Unix sockets in NewURLS
...
Resolves #12450
This commits adds support to unix/unixs socket URLs, which currently
fail with the message "URL address does not have the form "host:port".
It also replaces the work started in #11747 .
2021-10-07 11:59:32 +02:00
3bb7acc8cf
Migrate dependencies pkg/foo -> client/pkg/foo
2021-04-07 00:38:47 +02:00
de55bb6331
pkg: Rename imports after making 'pkg' a module
...
find -name '*.go' | xargs sed --follow-symlinks -i 's|go.etcd.io/etcd/v3/pkg/|go.etcd.io/etcd/pkg/v3/|g'
go fmt ./...
2020-10-13 00:09:27 +02:00
96cce208c2
go.mod: use go.etcd.io/etcd/v3 versioning
...
This change makes the etcd package compatible with the existing Go
ecosystem for module versioning.
Used this tool to update package imports:
https://github.com/KSubedi/gomove
2020-04-28 00:57:35 +00:00
ae983523db
pkg: remove capnslog ( #11616 )
...
* pkg: remove capnslog
* CHANGELOG: function signature change
2020-02-12 11:15:41 -08:00
34bd797e67
*: revert module import paths
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2019-05-28 15:39:35 -07:00
9150bf52d6
go modules: Fix module path version to include version number
2019-04-26 15:29:50 -07:00
7b32c07899
pkg/flags: fix "TestSetFlagsFromEnvParsingError"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2018-10-31 10:44:38 -07:00
d37f1521b7
*: update import paths to "go.etcd.io/etcd"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com >
2018-08-28 17:47:55 -07:00
1917e5c543
pkg/*: fix "unconvert" warnings
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-04-30 15:32:16 -07:00
089e8ffecb
pkg/flags: fix "Set"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-27 06:25:44 -07:00
b426217907
pkg/flags: add "UniqueURLs", "UniqueStrings"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
iii
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-27 06:25:44 -07:00
1640cdb044
pkg/flags: clean up, add "SelectiveStringsValue"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-19 02:23:06 -07:00
1e94968ffa
pkg/flags: support empty URLs string in NewURLsValue
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-15 01:18:57 -04:00
5e9d4652e0
pkg/flags: add "StringSliceFromFlag"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-14 21:32:24 -04:00
9e7ef79c26
pkg/flags: add "StringSlice"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-14 21:27:17 -04:00
748ab8c398
pkg/flags: fatal on conflicting environment variable
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com >
2018-03-02 10:36:59 -08:00
965d9806d5
pkg/flags: fix "SetFlagsFromEnv" error masking
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com >
2017-11-27 06:41:43 -08:00
9b92e1b2d0
flag: improve StringFlags by support set default value when init ( #8447 )
...
* flag: improve StringFlags by support set default value when init
when init flagSet, set default value should be moved to StringFlags init
func, which is more friendly
personal proposal
* flag: code improved for StringFlags
2017-08-28 00:02:11 -07:00
195744aea6
pkg/flags: warns on shadowed environment variable flags
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com >
2017-08-09 15:58:48 -07:00
e4b8c874d2
pkg/flags: fixed prefix checking of the env variables
2017-01-20 13:13:40 +05:30
a00ed609c3
pkg/flags: export 'FlagToEnv' for e2e tests
2016-10-14 11:15:28 -07:00
9473e9c30e
pkg: use etcd as logging repo
2016-09-29 15:29:38 +08:00
8ea6be38ba
*: remove old flag support
...
These legacy flags support are here only because we do not want
CoreOS updates to break people.
Now people will be aware of that they switch to etcd3. Do not need
to support 0.x flags any more.
2016-06-17 14:51:45 -07:00
8b77de4e99
pkg: update LICENSE header
2016-05-12 20:48:53 -07:00
a120ca16c0
etcdctlv3: accept evn for global configuration flags
2016-03-25 14:23:32 -07:00
bd832e5b0a
*: migrate Godeps to vendor/
2016-03-22 17:10:28 -07:00
81229dbea9
*: add missing package descriptions
...
This adds and updates package descriptions in etcd projects.
And also deletes some duplicate LICENSE statements.
2015-11-17 20:54:10 -08:00
c8f5e03b75
pkg/flags: print out evn usage information
2015-08-27 12:08:31 -07:00