86c6b5f2da
fix: enable usestdlibvars linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-11-07 10:28:48 +00:00
5858a08f1b
fix: enable require-error rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-31 08:33:34 +01:00
6883308899
Merge pull request #18800 from mmorel-35/testifylint/require-error
...
fix: enable require-error rule from testifylint in client, pkg and server packages
2024-10-30 23:03:01 +00:00
8ec90c6088
Merge pull request #18780 from mmorel-35/server/errorlint
...
fix: enable errorlint in server directory
2024-10-30 22:55:43 +00:00
694b0fbdb6
refactor Etcdserver.snapshot to extract compaction into a separate method
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-10-30 09:25:54 +00:00
3a3115122e
fix: enable require-error rule from testifylint in client, pkg and server packages
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-28 21:02:58 +01:00
3abdf612b3
fix: enable errorlint in server directory
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-26 08:16:47 +02:00
6d2b23224c
Merge pull request #18739 from veshij/leak_fix
...
etcdserver: terminate recvLoop on serverWatchStream.close()
2024-10-24 11:29:43 +02:00
8a0fd66db3
Fix risk of a partial write txn being applied
...
Signed-off-by: Shyam Jeedigunta <jeedigv@amazon.com >
2024-10-22 12:32:33 -07:00
77607356d9
[serverWatchStream] terminate recvLoop on sws.close()
...
Signed-off-by: Oleg Guba <oleg.guba@gmail.com >
2024-10-21 12:09:27 -07:00
ff4a8df3aa
fix: enable formatter rule from testifylint
...
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch >
2024-10-17 14:10:35 +02:00
6165f60419
fix: enable expected-actual rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-17 09:17:59 +00:00
7ecb72a2b4
fix: enable error-nil rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-17 07:22:40 +02:00
f0187c38d1
Merge pull request #18689 from mmorel-35/testifylint/nil-compare
...
fix: enable nil-compare rule from testifylint
2024-10-11 09:41:28 +01:00
de2c95dcba
fix: enable nil-compare rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-11 07:10:03 +02:00
33d7f2d53e
fix: enable gofmt and whitespace linters
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-11 07:03:18 +02:00
e06fb81713
fix: enable empty and len rules from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-10 11:07:21 +00:00
b23947b604
fix: enable bool-compare rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-06 09:47:02 +02:00
08d54bc5a8
Remove context from appliers
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-10-04 18:14:25 +02:00
7537341861
Remove context from dispatch
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-10-04 16:56:16 +02:00
ffdf5f2d06
Remove context from top level apply
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-10-04 16:06:55 +02:00
d012386222
Merge pull request #18606 from monogon-dev/fix-islearner-panic
...
etcdserver: fix panic when checking IsLearner of removed member
2024-10-04 10:50:12 +01:00
c1976a6717
Merge pull request #18617 from redwrasse/redwrasse/server/remaining-errors-is
...
server: remaining errors.Is conversions
2024-10-03 14:47:01 +02:00
4284a71a6c
fix(v3compactor): flaky TestPeriodicSkipRevNotChange test by increasing timeout
...
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch >
2024-10-02 10:36:37 +00:00
3374e27f19
etcdserver: fix panic when checking IsLearner of removed member
...
There was a concurrency bug when accessing the IsLearner
property of a member, which will panic with a nil pointer access error
if the member is removed between the IsMemberExist() and Member() calls.
Signed-off-by: Jan Schär <jan@monogon.tech >
2024-09-30 11:13:23 +02:00
0739142ee3
server: errors.Is conversions
...
Signed-off-by: redwrasse <mail@redwrasse.io >
2024-09-29 05:23:47 -07:00
2f9532bfca
Merge pull request #18608 from srivastav-abhishek/periodic-compaction-flake-fix
...
Fixed periodic compaction tests
2024-09-22 09:17:13 +01:00
b8cb654be6
Use strict synchronization for revision getter to minimize flaky result caused by time racing.
...
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com >
Addressed review comments
Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
2024-09-19 17:34:24 +05:30
d4df7a902e
Replaces a number of error equality checks with errors.Is
...
Signed-off-by: redwrasse <mail@redwrasse.io >
2024-09-03 16:02:24 -07:00
b8b0cf83d1
Skip leadership check if the etcd instance is active processing heartbeat
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2024-08-09 17:02:02 +01:00
bd228cf6d1
migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-08-05 13:46:51 -07:00
6a17ce3ff7
fix genproto after *.proto file update
...
Update genproto after *.proto change:
* Please rerun genproto.sh after changing *.proto file
* Run ./scripts/genproto.sh
Error encountered:
[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com >
2024-07-31 15:06:45 +05:30
d820cd2b56
etcdserver: change the snapshot + compact into sync operation
...
Signed-off-by: Clement <gh.2lgqz@aleeas.com >
2024-07-05 01:27:30 +08:00
60e3f45469
Adds all feature_gate from component-base.
...
We'll likely use most of the feature_gate package from component-base.
Also this commit moves the pkg from server/internal/pkg to pkg/.
Signed-off-by: Baek <seungtackbaek@google.com >
2024-06-15 05:34:58 +00:00
69ebaaebca
featuregate: adds EtcdServer.FeatureEnabled interface.
...
The interface can be used throughout the etcd server binary to check if
the feature is enabled or not.
Note that this commit also copies necessary FeatureGate interface from
k8s component-base.
Signed-off-by: Baek <seungtackbaek@google.com >
2024-06-15 05:34:58 +00:00
9431e3a952
dependency: bump google.golang.org/grpc from 1.63.2 to 1.64.0
...
Reference:
- https://github.com/etcd-io/etcd/pull/18034
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com >
2024-05-20 22:45:14 +02:00
0232686cac
etcdserver: add server range duration metrics
...
Signed-off-by: Daniel Tripp <38776199+thedtripp@users.noreply.github.com >
Co-authored-by: Ravi Hari <RaviHari@users.noreply.github.com >
2024-05-18 19:01:09 +00:00
36414cb0b8
Merge pull request #17930 from jamesreprise/bootstraped
...
Fix typo bootstrapedCluster
2024-05-03 18:07:49 +01:00
13c0f75b7d
Merge pull request #17877 from tjungblu/17872_status
...
add quota to endpoint status response
2024-05-03 13:03:23 +01:00
ccb4ef76e3
typo: bootstrapedCluster -> bootstrappedCluster
...
Signed-off-by: James Williams <james.williams@griffin.com >
2024-05-03 11:34:55 +01:00
030066cdb2
Chore: Use chain interceptors from grpc package
...
Signed-off-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2024-05-01 22:26:50 +02:00
d31caaec4a
Merge pull request #17793 from mneverov/fix-quorum-check
...
Fix remove member failed.
2024-04-30 19:52:14 +01:00
09f7d7ab92
Merge pull request #17875 from ivanvc/fix-deprecation-comments-added-with-var-naming-lint-rule
...
Fix deprecation comments from addressing var-naming work
2024-04-30 19:51:37 +01:00
dafadd13c1
all: don't convert byte slice to string when using verb %s
...
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-04-25 23:34:52 +08:00
bdcff246cb
add quota to endpoint status response
...
This adds the configured backend quota bytes to the endpoint status response.
related discussion in #17821
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com >
2024-04-25 16:44:20 +02:00
242f5d60a8
Fix deprecation comments from addressing var-naming work
...
The deprecation tag/comment must to be followed by an empty line.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-04-24 14:40:59 -07:00
379a8b79fb
fix version order when calling IsValidClusterVersionChange in UpdateCapability.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-23 09:31:19 -07:00
b6b7a1a3b6
refactor IsValidVersionChange.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-22 10:27:54 -07:00
c2982e15f3
Revert checking connected since inclusively.
...
Signed-off-by: Max Neverov <neverov.max@gmail.com >
2024-04-18 11:26:28 +02:00
c64c996c03
Revert quorum calculation: (active - 1) < 1+((len(m)-1)/2) calculates quorum after a member is deleted.
...
Signed-off-by: Max Neverov <neverov.max@gmail.com >
2024-04-17 07:55:24 +02:00
