Commit Graph

1999 Commits

Author SHA1 Message Date
3374e27f19 etcdserver: fix panic when checking IsLearner of removed member
There was a concurrency bug when accessing the IsLearner
property of a member, which will panic with a nil pointer access error
if the member is removed between the IsMemberExist() and Member() calls.

Signed-off-by: Jan Schär <jan@monogon.tech>
2024-09-30 11:13:23 +02:00
0739142ee3 server: errors.Is conversions
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-29 05:23:47 -07:00
dcdfead770 Bump go toolchain to 1.23.1
Reference:
- https://github.com/etcd-io/etcd/issues/18543
- https://github.com/kubernetes/release/issues/3650

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-26 22:38:57 +02:00
79f31c7a5d dependency: bump go.opentelemetry.io/otel from 1.29.0 to 1.30.0
In summary, the bump is performed for the following dependencies:
- go.opentelemetry.io/otel/exporters/otlp/otlptrace from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/metric from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/sdk from v1.29.0 to v1.30.0
- go.opentelemetry.io/otel/trace from v1.29.0 to v1.30.0

This commit also addressed the following issues
FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/api
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240822170219-fc7c04adadcd (indirect) from: go.etcd.io/etcd/client/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240822170219-fc7c04adadcd (indirect) from: go.etcd.io/etcd/etcdctl/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240822170219-fc7c04adadcd from: go.etcd.io/etcd/api/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/etcdutl/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tests/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tools/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 from: go.etcd.io/etcd/server/v3
  - google.golang.org/genproto/googleapis/api@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tools/v3
FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240903143218-8af14fe29dc1 (indirect) from: go.etcd.io/etcd/api/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240903143218-8af14fe29dc1 (indirect) from: go.etcd.io/etcd/client/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240903143218-8af14fe29dc1 (indirect) from: go.etcd.io/etcd/etcdctl/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240903143218-8af14fe29dc1 (indirect) from: go.etcd.io/etcd/pkg/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240903143218-8af14fe29dc1 (indirect) from: go.etcd.io/etcd/tools/testgrid-analysis/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/etcdutl/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/server/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tests/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tools/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/v3
  - google.golang.org/genproto/googleapis/rpc@v0.0.0-20240924160255-9d4c2d233b61 (indirect) from: go.etcd.io/etcd/tools/v3
FAIL: inconsistent dependencies

Reference:
- https://github.com/etcd-io/etcd/pull/18629
- https://github.com/etcd-io/etcd/pull/18630
- https://github.com/etcd-io/etcd/pull/18626
- https://github.com/etcd-io/etcd/pull/18627

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-26 00:40:27 +02:00
4d4008164e dependency: bump google.golang.org/grpc from 1.66.0 to 1.67.0
Reference:
- https://github.com/etcd-io/etcd/pull/18628

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-25 22:43:51 +02:00
d77c9ac5c2 dependency: bump github.com/prometheus/client_golang from 1.20.3 to 1.20.4
Reference:
- https://github.com/etcd-io/etcd/pull/18631

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-25 22:43:51 +02:00
680eadf0d6 Add function to create WAL files
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
2024-09-24 12:55:24 -05:00
35edbf91ad dependency: bump github.com/golangci/golangci-lint from 1.60.3 to 1.61.0 and google.golang.org/genproto/googleapis/rpc from v0.0.0-20240822170219-fc7c04adadcd to v0.0.0-20240903143218-8af14fe29dc1
Also fix the inconsistent version issue.

Reference:
- https://github.com/etcd-io/etcd/pull/18596

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-22 17:50:56 +02:00
1199fa89a0 dependency: bump golang.org/x/net from 0.28.0 to 0.29.0
Reference:
- https://github.com/etcd-io/etcd/pull/18597

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-22 17:50:12 +02:00
2f9532bfca Merge pull request #18608 from srivastav-abhishek/periodic-compaction-flake-fix
Fixed periodic compaction tests
2024-09-22 09:17:13 +01:00
1820d3b7d5 Merge pull request #18510 from redwrasse/redwrasse/errors-is
Use errors.Is for error equality checks
2024-09-20 09:02:40 +02:00
b8cb654be6 Use strict synchronization for revision getter to minimize flaky result caused by time racing.
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com>

Addressed review comments

Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-09-19 17:34:24 +05:30
d12bb7e0fb Ensure consistent file permissions on broken WAL
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
2024-09-16 14:07:16 -05:00
14d54893e0 dependency: bump golang.org/x/crypto from 0.26.0 to 0.27.0
golang.org/x/sys and golang.org/x/text version inconsistency are also
addressed:
- bump golang.org/x/sys from 0.24.0 to 0.25.0
- bump golang.org/x/text from 0.17.0 to 0.18.0

Reference:
- https://github.com/etcd-io/etcd/pull/18563
- https://github.com/etcd-io/etcd/pull/18558
- https://github.com/etcd-io/etcd/pull/18566
- https://github.com/etcd-io/etcd/pull/18565

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-14 22:29:31 +02:00
a976ba136d dependency: bump github.com/prometheus/client_golang from 1.20.2 to 1.20.3
Reference:
- https://github.com/etcd-io/etcd/pull/18564
- https://github.com/etcd-io/etcd/pull/18559

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-14 22:10:04 +02:00
636f191368 dependency: bump github.com/prometheus/common from 0.57.0 to 0.59.1
Reference:
- https://github.com/etcd-io/etcd/pull/18562
- https://github.com/etcd-io/etcd/pull/18567

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-14 21:48:11 +02:00
29f3bc2222 Bump go toolchain to 1.22.7
Reference:
- https://github.com/etcd-io/etcd/issues/18443
- https://github.com/etcd-io/etcd/issues/18548#issuecomment-2343061825

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-11 15:32:52 +02:00
a042354947 Fix races in TestLessorRenewExtendPileup
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
2024-09-09 10:39:44 -05:00
d4df7a902e Replaces a number of error equality checks with errors.Is
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-03 16:02:24 -07:00
b3a0047c80 dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.53.0 to 0.54.0
Reference:
- https://github.com/etcd-io/etcd/pull/18525

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-03 16:33:50 +02:00
bd246ea174 dependency: bump github.com/prometheus/common from 0.55.0 to 0.57.0
Reference:
- https://github.com/etcd-io/etcd/pull/18529
- https://github.com/etcd-io/etcd/pull/18523

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-03 16:30:25 +02:00
2cd46694b9 dependency: bump google.golang.org/grpc from 1.65.0 to 1.66.0
Reference:
- https://github.com/etcd-io/etcd/pull/18530
- https://github.com/etcd-io/etcd/pull/18524

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-03 16:27:55 +02:00
c2d4f2b694 dependency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.27.0 to 1.29.0
Reference:
- https://github.com/etcd-io/etcd/pull/18515

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-30 22:58:26 +02:00
077817058f dependency: bump github.com/prometheus/client_golang from 1.20.0 to 1.20.2
Reference:
- https://github.com/etcd-io/etcd/pull/18492

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-29 22:12:13 +02:00
40fc67e88a dependency: bump go.opentelemetry.io/otel/sdk from 1.28.0 to 1.29.0
Reference:
- https://github.com/etcd-io/etcd/pull/18497

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-29 22:12:13 +02:00
7ef38ee7ec dependency: bump go.opentelemetry.io/otel from 1.28.0 to 1.29.0 and bump go.opentelemetry.io/otel/trace from 1.28.0 to 1.29.
Reference:
- https://github.com/etcd-io/etcd/pull/18499
- https://github.com/etcd-io/etcd/pull/18498

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-29 22:12:13 +02:00
f56a0a4e82 dependency: bump github.com/google/btree from 1.1.2 to 1.1.3
Reference:
- https://github.com/etcd-io/etcd/pull/18500

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-29 22:12:13 +02:00
2c53be7c5d etcdserver: rename defaultCompactionSleepInterval var (#18495)
* etcdserver: rename `minimumBatchInterval`  to `defaultCompactionSleepInterval` and `defaultCompactBatchLimit` to `defaultCompactionBatchLimit`

Signed-off-by: Jalin Wang <JalinWang@outlook.com>
2024-08-27 14:36:06 +01:00
e794407f3f dependency: bump github.com/prometheus/client_golang from 1.19.1 to 1.20.0
Reference:
- https://github.com/etcd-io/etcd/pull/18469
- https://github.com/etcd-io/etcd/pull/18466

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-24 03:10:29 +02:00
d23c2c7a16 dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.21.0 to 2.22.0
Reference:
- https://github.com/etcd-io/etcd/pull/18470
- https://github.com/etcd-io/etcd/pull/18467

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-24 03:10:29 +02:00
a966c07165 migrate experimental-initial-corrupt-check flag to feature gate.
Signed-off-by: Lan Liang <gcslyp@gmail.com>
2024-08-22 14:42:18 +00:00
1d0a6b3978 Merge pull request #18274 from fuweid/fix-event-loss-caused-by-compact
*: keep tombstone if revision == compactAtRev
2024-08-16 08:16:04 +01:00
a8b30b19bd Merge pull request #18428 from ahrtr/improve_leaseRenew_20240809
Skip leadership check if the etcd instance is active processing heartbeats
2024-08-14 15:58:04 +01:00
b8b0cf83d1 Skip leadership check if the etcd instance is active processing heartbeat
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-08-09 17:02:02 +01:00
6208673ebf dependency: bump golang.org/x/sys from 0.23.0 to 0.24.0
Reference:
- https://github.com/etcd-io/etcd/pull/18426
- https://github.com/etcd-io/etcd/pull/18425

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-09 10:17:01 +02:00
9c187ef337 Merge pull request #18420 from henrybear327/go/1.22.6
go version bump from 1.22.5 to 1.22.6
2024-08-08 22:02:17 +01:00
8eb943d2af dependency: bump golang.org/x/net from 0.27.0 to 0.28.0
Due to bumping github.com/alexfalkowski/gocovmerge

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:43:41 +02:00
5c290d110d dependency: bump golang.org/x/crypto from 0.25.0 to 0.26.0
Due to bumping github.com/alexfalkowski/gocovmerge

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:40:19 +02:00
794d1b64f7 go version bump from 1.22.5 to 1.22.6
Reference: https://github.com/etcd-io/etcd/issues/18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:30:09 +02:00
f071fde896 dependency: bump golang.org/x/sys from 0.22.0 to 0.23.0
Reference:
- https://github.com/etcd-io/etcd/pull/18406

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:24:07 +02:00
cfe806aab7 dependency: bump golang.org/x/time from 0.5.0 to 0.6.0
Reference:
- https://github.com/etcd-io/etcd/pull/18401

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:24:07 +02:00
bbdc94181a *: keep tombstone if revision == compactAtRev
Before this patch, the tombstone can be deleted if its revision is equal
compacted revision. It causes that the watch subscriber won't get this
DELETE event. Based on Compact API[1], we should keep tombstone revision
if it's not less than the compaction revision.

> CompactionRequest compacts the key-value store up to a given revision.
> All superseded keys with a revision less than the compaction revision
> will be removed.

[1]: https://etcd.io/docs/latest/dev-guide/api_reference_v3/

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-08-07 21:56:20 +08:00
bd228cf6d1 migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-08-05 13:46:51 -07:00
6a17ce3ff7 fix genproto after *.proto file update
Update genproto after *.proto change:
* Please rerun genproto.sh after changing *.proto file
* Run ./scripts/genproto.sh

Error encountered:
[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-31 15:06:45 +05:30
984100b3a6 dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0
This commit will bump dependency bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-31 14:16:18 +05:30
9f59ef8ead Merge pull request #18365 from siyuanfoundation/fg-1
Add config file field for feature-gates flag.
2024-07-26 10:11:43 +02:00
9a6c9aeeab Merge pull request #18283 from clement2026/change-snapshot-and-compact-into-sync-operation
etcdserver: change the snapshot + compact into sync operation
2024-07-24 10:43:03 +02:00
0e77563e35 Add config file field for feature-gates flag.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-07-23 15:27:07 -07:00
3b4e2f4668 Merge pull request #18279 from siyuanfoundation/fg-1
Add "server-feature-gates" flag.
2024-07-23 15:27:35 +02:00
d6c0127d26 Merge pull request #18321 from fuweid/mvcc-test/should-not-allow-duplicate-keys-in-one-txn
mvcc/*_test.go: should not use duplicate revision.Main for one key
2024-07-20 06:13:03 +01:00