t-reftable-readwrite: use free_names() instead of a for loop
free_names() as defined by reftable/basics.{c,h} frees a NULL terminated array of malloced strings along with the array itself. Use this function instead of a for loop to free such an array. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
5b539a5361
commit
3dd4fb13a0
@ -7,6 +7,7 @@ https://developers.google.com/open-source/licenses/bsd
|
||||
*/
|
||||
|
||||
#include "test-lib.h"
|
||||
#include "reftable/basics.h"
|
||||
#include "reftable/blocksource.h"
|
||||
#include "reftable/reader.h"
|
||||
#include "reftable/reftable-error.h"
|
||||
@ -413,7 +414,6 @@ static void t_table_read_api(void)
|
||||
struct reftable_reader rd = { 0 };
|
||||
struct reftable_block_source source = { 0 };
|
||||
int err;
|
||||
int i;
|
||||
struct reftable_log_record log = { 0 };
|
||||
struct reftable_iterator it = { 0 };
|
||||
|
||||
@ -432,10 +432,8 @@ static void t_table_read_api(void)
|
||||
check_int(err, ==, REFTABLE_API_ERROR);
|
||||
|
||||
strbuf_release(&buf);
|
||||
for (i = 0; i < N; i++)
|
||||
reftable_free(names[i]);
|
||||
free_names(names);
|
||||
reftable_iterator_destroy(&it);
|
||||
reftable_free(names);
|
||||
reader_close(&rd);
|
||||
strbuf_release(&buf);
|
||||
}
|
||||
@ -498,9 +496,7 @@ static void t_table_read_write_seek(int index, int hash_id)
|
||||
reftable_iterator_destroy(&it);
|
||||
|
||||
strbuf_release(&buf);
|
||||
for (i = 0; i < N; i++)
|
||||
reftable_free(names[i]);
|
||||
reftable_free(names);
|
||||
free_names(names);
|
||||
reader_close(&rd);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user