mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t: improve the test-case for parse_names()

Browse Source 
In the existing test-case for parse_names(), the fact that empty
lines should be ignored is not obvious because the empty line is
immediately followed by end-of-string. This can be mistaken as the
empty line getting replaced by NULL. Improve this by adding a
non-empty line after the empty one to demonstrate the intended behavior.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Chandra Pratap
2024-05-29 22:29:31 +05:30
committed by Junio C Hamano
parent e31efffc28
commit efa8786800
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
t/unit-tests/t-reftable-basics.c
View File

@ -89,11 +89,13 @@ static void test_parse_names_normal(void)
static void test_parse_names_drop_empty(void)
{
char in[] = "a\n\n";
char in[] = "a\n\nb\n";
char **out = NULL;
parse_names(in, strlen(in), &out);
check_str(out[0], "a");
check(!out[1]);
/* simply '\n' should be dropped as empty string */
check_str(out[1], "b");
check(!out[2]);
free_names(out);
}