Johannes Schindelin 3dfd30598b fsmonitor: fix memory corruption in some corner cases
In 56c6910028 (fsmonitor: change last update timestamp on the
index_state to opaque token, 2020-01-07), we forgot to adjust the part
of `unpack_trees()` that copies the FSMonitor "last-update" information
that we copy from the source index to the result index since 679f2f9fdd
(unpack-trees: skip stat on fsmonitor-valid files, 2019-11-20).

Since the "last-update" information is no longer a 64-bit number, but a
free-form string that has been allocated, we need to duplicate it rather
than just copying it.

This is important because there _are_ cases when `unpack_trees()` will
perform a oneway merge that implicitly calls `refresh_fsmonitor()`
(which will allocate that "last-update" token). This happens _after_
that token was copied into the result index. However, we _then_ call
`check_updates()` on that index, which will _also_ call
`refresh_fsmonitor()`, accessing the "last-update" string, which by now
would be released already.

In the instance that lead to this patch, this caused a segmentation
fault during a lengthy, complicated rebase involving the todo command
`reset` that (crucially) had to updated many files. Unfortunately, it
seems very hard to trigger that crash, therefore this patch is not
accompanied by a regression test.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-03-17 12:19:26 -07:00
2021-02-12 15:51:12 +01:00
2021-02-12 15:51:13 +01:00
2020-11-09 14:06:25 -08:00
2021-02-12 15:51:12 +01:00
2020-12-08 15:11:21 -08:00
2020-12-08 15:11:17 -08:00
2020-12-18 15:15:18 -08:00
2020-11-21 15:14:38 -08:00
2020-09-02 14:39:25 -07:00
2020-11-18 13:32:53 -08:00
2021-02-12 15:51:12 +01:00
2020-09-30 12:53:47 -07:00
2020-11-12 09:40:06 -08:00
2020-12-18 15:15:18 -08:00
2020-11-02 13:17:44 -08:00
2020-11-21 15:14:38 -08:00
2020-09-03 12:37:04 -07:00
2020-11-09 14:06:25 -08:00
2021-02-12 15:51:12 +01:00
2021-02-12 15:51:13 +01:00
2020-11-30 13:55:54 -08:00
2020-12-14 15:01:03 -08:00
2021-01-06 13:53:32 -08:00
2020-11-21 15:14:38 -08:00
2020-11-25 15:24:52 -08:00
2020-12-08 15:11:18 -08:00
2020-08-28 14:07:09 -07:00
2020-12-14 10:21:36 -08:00
2020-10-27 15:09:50 -07:00
2021-02-12 15:51:13 +01:00
2020-10-27 15:09:49 -07:00
2021-02-12 15:51:12 +01:00
2020-11-21 15:14:38 -08:00
2020-09-02 14:39:25 -07:00
2021-02-12 15:49:35 +01:00
2020-11-02 13:17:46 -08:00
2020-10-05 14:01:52 -07:00
2020-10-05 14:01:52 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 235 MiB
Languages
C 50.1%
Shell 38.4%
Perl 5.1%
Tcl 3.3%
Python 0.8%
Other 2%