Jonathan Nieder aafa5df0df xsize_t: avoid implementation defined behavior when len < 0
The xsize_t helper aims to safely convert an off_t to a size_t,
erroring out when a file offset is too large to fit into a memory
address.  It does this by using two casts:

	size_t size = (size_t) len;
	if (len != (off_t) size)
		... error out ...

On a platform with sizeof(size_t) < sizeof(off_t), this check is safe
and correct.  The first cast truncates to a size_t by finding the
remainder modulo SIZE_MAX+1 (see C99 section 6.3.1.3 Signed and
unsigned integers) and the second promotes to an off_t, meaning the
result is true if and only if len is representable as a size_t.

On other platforms, this two-casts strategy still works well (always
succeeds) for len >= 0.  But for len < 0, when the first cast succeeds
and produces SIZE_MAX + 1 + len, the resulting value is too large to
be represented as an off_t, so the second cast produces implementation
defined behavior.  In practice, it is likely to produce a result of
true despite len not being representable as size_t.

Simplify by replacing with a more straightforward check: compare len
to the relevant bounds and then cast it.  (To avoid a -Wsign-compare
warning, after checking that len >= 0, we explicitly convert to a
sufficiently-large unsigned type before comparing to SIZE_MAX.)

In practice, this is not likely to come up since typical callers use
nonnegative len.  Still, it's helpful to handle this case to make the
behavior easy to reason about.

Historical note: the original bounds-checking in 46be82dfd0 (xsize_t:
check whether we lose bits, 2010-07-28) did not produce this
implementation-defined behavior, though it still did not handle
negative offsets.  It was not until 73560c793a (git-compat-util.h:
xsize_t() - avoid -Wsign-compare warnings, 2017-09-21) introduced the
double cast that the implementation-defined behavior was triggered.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-05-19 15:00:30 +09:00
2021-03-26 14:49:41 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-19 15:25:38 -07:00
2020-12-08 15:11:21 -08:00
2021-01-21 15:50:00 -08:00
2020-12-08 15:11:17 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2020-11-18 13:32:53 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-01-23 17:14:07 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-01-25 14:19:19 -08:00
2021-02-17 17:21:40 -08:00
2021-03-13 16:00:09 -08:00
2020-11-12 09:40:06 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-25 16:43:30 -08:00
2021-03-13 16:00:09 -08:00
2021-02-16 09:30:42 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-26 14:49:41 -07:00
2021-02-12 14:21:04 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-22 12:07:40 -08:00
2021-03-13 16:00:09 -08:00
2020-12-14 15:01:03 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-17 17:21:40 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-19 15:25:38 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-05 16:40:45 -08:00
2020-12-14 10:21:36 -08:00
2021-03-26 14:49:41 -07:00
2021-03-13 16:00:09 -08:00
2021-02-17 17:21:40 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-05 16:40:44 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-12 15:49:35 +01:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-02-05 13:49:55 -08:00
2021-01-04 15:23:08 -08:00
2021-02-09 14:14:34 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 235 MiB
Languages
C 50.1%
Shell 38.4%
Perl 5.1%
Tcl 3.3%
Python 0.8%
Other 2%