Derrick Stolee b64b0df9da scalar: avoid segfault in reconfigure --all
During the latest v2.45.0 update, 'scalar reconfigure --all' started to
segfault on my machine. Breaking it down via the debugger, it was
faulting on a NULL reference to the_hash_algo, which is a macro pointing
to the_repository->hash_algo.

In my case, this is due to one of my repositories having a detached HEAD,
which requires get_oid_hex() to parse that the HEAD reference is valid.
Another way to cause a failure is to use the "includeIf.onbranch" config
key, which will lead to a BUG() statement.

My first inclination was to try to refactor cmd_reconfigure() to execute
'git for-each-repo' instead of this loop. In addition to the difficulty
of executing 'scalar reconfigure' within 'git for-each-repo', it would
be difficult to perform the clean-up logic for non-existent repos if we
relied on that child process.

Instead, I chose to move the temporary repo to be within the loop and
reinstate the_repository to its old value after we are done performing
logic on the current array item.

Add tests to t9210-scalar.sh to test 'scalar reconfigure --all' with
multiple registered repos. There are two different ways that the old
use of the_repository could trigger bugs. These issues are being solved
independently to be more careful about the_repository being
uninitialized, but the change in this patch around the use of
the_repository is still a good safety precaution.

Co-authored-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Derrick Stolee <stolee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-05-07 17:51:12 -07:00
2024-04-25 10:34:24 -07:00
2024-03-15 10:47:05 -07:00
2024-04-09 14:31:45 -07:00
2024-04-25 10:34:24 -07:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-04-05 10:49:49 -07:00
2024-03-28 14:13:50 -07:00
2024-04-05 15:21:14 -07:00
2024-04-05 15:21:14 -07:00
2024-03-28 14:13:50 -07:00
2024-04-29 07:30:29 -07:00
2024-03-28 14:13:50 -07:00
2024-02-26 09:35:40 -08:00
2024-03-28 14:13:50 -07:00
2024-04-23 11:52:40 -07:00
2024-02-26 15:34:01 -08:00
2024-02-26 15:34:01 -08:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-04-05 15:21:14 -07:00
2024-04-05 15:21:14 -07:00
2024-04-05 15:21:14 -07:00
2024-03-28 14:13:50 -07:00
2024-03-05 09:44:44 -08:00
2024-02-26 18:10:25 -08:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-04-23 11:52:41 -07:00
2024-03-07 15:59:41 -08:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-03-02 11:12:16 -08:00
2024-04-05 10:49:49 -07:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-03-28 14:13:50 -07:00
2024-04-05 15:16:27 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 235 MiB
Languages
C 50.1%
Shell 38.4%
Perl 5.1%
Tcl 3.3%
Python 0.8%
Other 2%