Commit Graph

280 Commits

Author SHA1 Message Date
Wei Fu
8575de3bab v3rpc: add DowngradeInfo in status API
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2025-02-19 17:18:08 -05:00
adeyemi
6f27da2aee Move AlarmBackend interface to fix unexported-return
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2025-02-16 21:22:53 -08:00
Benjamin Wang
a9b8cba602 Migrate experimental distributed tracing flags to non-experimental flags
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-11 15:29:16 +00:00
Benjamin Wang
dfbdd8853c Add learner id into log when being promoted
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-02-04 13:10:42 +00:00
Benjamin Wang
d52bceb2f1
Merge pull request #19192 from wodeyoulai/main
Correct compaction period comments
2025-01-31 18:45:31 +00:00
Davanum Srinivas
3648220e22
incorporate feedback from review
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2025-01-31 06:44:29 -05:00
Davanum Srinivas
c3e4df6de1
Switch from grpc-ecosystem/go-grpc-prometheus to grpc-ecosystem/go-grpc-middleware/providers/prometheus
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2025-01-30 08:43:53 -05:00
Benjamin Wang
614640f1c2 format all prometheus metrics to ensure nice indent
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-01-29 13:42:14 +00:00
Marek Siarkowicz
c9045d650e
Merge pull request #19086 from gojoy/readyz-learner
etcdserver: add learner check to readyz
2025-01-22 11:05:42 +01:00
Guo Jix
989c556645
etcdserver: add learner check to readyz
Signed-off-by: GitHub <noreply@github.com>
2025-01-22 02:12:44 +00:00
wodeyoulai
7da675a327
docs: correct compaction period comments for 24-hour window
Update compaction period logic in periodic compactor to consistently
use 24-hour intervals instead of 1-hour. This fixes incorrect time
calculations where:
- Compaction period now correctly uses 24-hour instead of 1-hour
- Revision recording interval updated to 144-minute (1/10 of 24-hour)
  instead of 6-minute
- Retry interval on compaction failure adjusted to 144-minute to
  match the new period

This ensures consistent time-based compaction behavior for 24-hour
windows as originally intended.

Fixes #[issue-19017]

Signed-off-by: wodeyoulai <106662970@qq.com>
2025-01-18 17:39:30 +08:00
Matthieu MOREL
10d7cea552 chore: enable early-return and superfluous-else from revive
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Co-authored-by: Iván Valdés Castillo <iv@nvald.es>
2025-01-18 09:44:58 +01:00
Benjamin Wang
8d0f165fd5 Minor refactor on RaftCluster.Recover()
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2025-01-15 16:26:47 +00:00
Chun-Hung Tseng
1430c1d8c1 dependency: bump github.com/jonboulle/clockwork from 0.4.0 to 0.5.0
Bumping this dependency also require fixing func newFakeClock() to
return a pointer to the struct (*clockwork.FakeClock)

Reference:
- https://github.com/etcd-io/etcd/pull/19131

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2025-01-12 21:20:16 +01:00
adeyemi
a1a9149bbb Fix typo in typo fix
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2025-01-08 10:54:00 -08:00
adeyemi
05ff6333a9 Rephrase warn messaging
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2024-12-27 21:15:14 -08:00
adeyemi
7577a56c1f Update misleading warn message when versions mismatch
Signed-off-by: adeyemi <adeyemi.aladesawe@gmail.com>
2024-12-27 09:49:22 -08:00
Matthieu MOREL
647f1621d6 fix: enable gosimple linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-12-03 07:32:22 +01:00
Marek Siarkowicz
c77ea65979 Reuse grpcOverheadBytes calculation by creating a function for that
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-12-02 19:04:38 +01:00
James Blair
46127e7ea5
Merge pull request #18961 from ArkaSaha30/deps_mgmt_25_11_24
[2024-11-25] Manual Dependency Bump
2024-11-29 20:09:47 -07:00
Marek Siarkowicz
6cebf973a1 Run a separate in memory snapshot to reduce number of entries stored in raft memory storage
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-11-29 20:40:02 +01:00
ArkaSaha30
4cce12a724
Fix genproto annotations
* Please add etcd_version annotation in *.proto file with next etcd version
* Run ./scripts/genproto.sh
push_pin
* Run ./scripts/update_proto_annotations.sh

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-11-29 16:39:53 +05:30
Matthieu MOREL
69efe31ea0 fix: enable gofumpt instead of gofmt linter in server
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-11-27 07:22:36 +01:00
Matthieu MOREL
86c6b5f2da fix: enable usestdlibvars linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-11-07 10:28:48 +00:00
Matthieu MOREL
5858a08f1b fix: enable require-error rule from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-31 08:33:34 +01:00
Benjamin Wang
6883308899
Merge pull request #18800 from mmorel-35/testifylint/require-error
fix: enable require-error rule from testifylint in client, pkg and server packages
2024-10-30 23:03:01 +00:00
Matthieu MOREL
3a3115122e fix: enable require-error rule from testifylint in client, pkg and server packages
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-28 21:02:58 +01:00
Matthieu MOREL
3abdf612b3 fix: enable errorlint in server directory
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-26 08:16:47 +02:00
Marek Siarkowicz
6d2b23224c
Merge pull request #18739 from veshij/leak_fix
etcdserver: terminate recvLoop on serverWatchStream.close()
2024-10-24 11:29:43 +02:00
Oleg Guba
77607356d9 [serverWatchStream] terminate recvLoop on sws.close()
Signed-off-by: Oleg Guba <oleg.guba@gmail.com>
2024-10-21 12:09:27 -07:00
Thomas Gosteli
ff4a8df3aa fix: enable formatter rule from testifylint
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch>
2024-10-17 14:10:35 +02:00
Matthieu MOREL
6165f60419 fix: enable expected-actual rule from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-17 09:17:59 +00:00
Matthieu MOREL
7ecb72a2b4 fix: enable error-nil rule from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-17 07:22:40 +02:00
Benjamin Wang
f0187c38d1
Merge pull request #18689 from mmorel-35/testifylint/nil-compare
fix: enable nil-compare rule from testifylint
2024-10-11 09:41:28 +01:00
Matthieu MOREL
de2c95dcba fix: enable nil-compare rule from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-11 07:10:03 +02:00
Matthieu MOREL
33d7f2d53e fix: enable gofmt and whitespace linters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-11 07:03:18 +02:00
Matthieu MOREL
e06fb81713 fix: enable empty and len rules from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-10 11:07:21 +00:00
Matthieu MOREL
b23947b604 fix: enable bool-compare rule from testifylint
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-10-06 09:47:02 +02:00
Benjamin Wang
d012386222
Merge pull request #18606 from monogon-dev/fix-islearner-panic
etcdserver: fix panic when checking IsLearner of removed member
2024-10-04 10:50:12 +01:00
Marek Siarkowicz
c1976a6717
Merge pull request #18617 from redwrasse/redwrasse/server/remaining-errors-is
server: remaining errors.Is conversions
2024-10-03 14:47:01 +02:00
Thomas Gosteli
4284a71a6c fix(v3compactor): flaky TestPeriodicSkipRevNotChange test by increasing timeout
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch>
2024-10-02 10:36:37 +00:00
Jan Schär
3374e27f19 etcdserver: fix panic when checking IsLearner of removed member
There was a concurrency bug when accessing the IsLearner
property of a member, which will panic with a nil pointer access error
if the member is removed between the IsMemberExist() and Member() calls.

Signed-off-by: Jan Schär <jan@monogon.tech>
2024-09-30 11:13:23 +02:00
redwrasse
0739142ee3 server: errors.Is conversions
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-29 05:23:47 -07:00
Benjamin Wang
2f9532bfca
Merge pull request #18608 from srivastav-abhishek/periodic-compaction-flake-fix
Fixed periodic compaction tests
2024-09-22 09:17:13 +01:00
Joshua Zhang
b8cb654be6 Use strict synchronization for revision getter to minimize flaky result caused by time racing.
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com>

Addressed review comments

Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-09-19 17:34:24 +05:30
redwrasse
d4df7a902e Replaces a number of error equality checks with errors.Is
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-03 16:02:24 -07:00
Siyuan Zhang
bd228cf6d1 migrate experimental-stop-grpc-service-on-defrag flag to feature gate.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-08-05 13:46:51 -07:00
ArkaSaha30
6a17ce3ff7
fix genproto after *.proto file update
Update genproto after *.proto change:
* Please rerun genproto.sh after changing *.proto file
* Run ./scripts/genproto.sh

Error encountered:
[0;31mFAIL: 'genproto' FAILED at Wed Jul 31 07:09:08 UTC 2024
make: *** [Makefile:134: verify-genproto] Error 255

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-31 15:06:45 +05:30
Chun-Hung Tseng
9431e3a952 dependency: bump google.golang.org/grpc from 1.63.2 to 1.64.0
Reference:
- https://github.com/etcd-io/etcd/pull/18034

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-20 22:45:14 +02:00
Benjamin Wang
13c0f75b7d
Merge pull request #17877 from tjungblu/17872_status
add quota to endpoint status response
2024-05-03 13:03:23 +01:00