030066cdb2
Chore: Use chain interceptors from grpc package
...
Signed-off-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2024-05-01 22:26:50 +02:00
09f7d7ab92
Merge pull request #17875 from ivanvc/fix-deprecation-comments-added-with-var-naming-lint-rule
...
Fix deprecation comments from addressing var-naming work
2024-04-30 19:51:37 +01:00
dafadd13c1
all: don't convert byte slice to string when using verb %s
...
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-04-25 23:34:52 +08:00
bdcff246cb
add quota to endpoint status response
...
This adds the configured backend quota bytes to the endpoint status response.
related discussion in #17821
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com >
2024-04-25 16:44:20 +02:00
242f5d60a8
Fix deprecation comments from addressing var-naming work
...
The deprecation tag/comment must to be followed by an empty line.
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-04-24 14:40:59 -07:00
379a8b79fb
fix version order when calling IsValidClusterVersionChange in UpdateCapability.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-23 09:31:19 -07:00
b6b7a1a3b6
refactor IsValidVersionChange.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2024-04-22 10:27:54 -07:00
bc31162cc2
all: call Close() after reading http.Response.Body
...
As the doc of http.Response.Body says:
// The http Client and Transport guarantee that Body is always
// non-nil, even on responses without a body or responses with
// a zero-length body. It is the caller's responsibility to
// close Body.
Signed-off-by: Jes Cok <xigua67damn@gmail.com >
2024-03-25 12:17:47 +08:00
97029d768a
Merge pull request #17614 from ivanvc/address-etcdserver-var-naming-lint-rule
...
etcdserver: address var naming lint rule
2024-03-19 22:40:03 +01:00
14523bdc21
etcdserver: rename MemberId() to MemberID() to address var-naming
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-18 17:18:29 -07:00
c613b78e6c
etcdserver: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es >
2024-03-18 17:17:07 -07:00
405862e807
Fix event loss after compaction
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2024-03-15 14:22:37 -07:00
6103504d4b
Fix progress notification for watch that doesn't get any events
...
When implementing the fix for progress notifications
(https://github.com/etcd-io/etcd/pull/15237 ) we made a incorrect
assumption that that unsynched watches will always get at least one event.
Unsynched watches include not only slow watchers, but also newly created
watches that requested current or older revision. In case that non of the events
match watch filter, those newly created watches might become synched
without any event going through.
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2024-03-11 12:11:09 +01:00
40f22e9319
Merge pull request #17176 from YaoC/fix-learner-metric
...
server: fix learner metric incorrect issue
2024-01-12 17:37:46 +01:00
f7ab7adf29
server: fix learner metric incorrect issue
...
Signed-off-by: YaoC <chengyao09@hotmail.com >
2024-01-12 09:36:33 +00:00
28f4c6fef6
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.1 to 2.19.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com >
2024-01-09 16:26:47 +01:00
bc697bc26e
Revert "Switch to validating v3 when v2 and v3 are synchronized"
...
This reverts commit 4fe46f9203siarkowicz@google.com >
2023-12-03 18:12:09 +01:00
fbdf65f101
Test v3 storage configuration validation
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-11-27 12:00:47 +01:00
e1d79097d5
Merge pull request #17017 from serathius/switch-validation-v3
...
Switch to validating v3 when v2 and v3 are synchronized
2023-11-27 10:50:14 +00:00
a97052acf4
remove unused method and functions
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com >
2023-11-25 16:16:52 +00:00
4fe46f9203
Switch to validating v3 when v2 and v3 are synchronized
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2023-11-24 17:46:33 +01:00
12b640523a
etcdserver: add linearizable_read check to readyz.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2023-11-21 11:13:20 -08:00
3897103b77
etcdserver: add metric counters for livez/readyz health checks.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2023-11-14 09:26:00 -08:00
2b7e1c6f82
fix scripts
...
Signed-off-by: Tessa Pham <hpham111@bloomberg.net >
2023-11-08 00:27:13 -06:00
8a6c1335e2
v3rpc: run health notifier to listen on online defrag state change
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-28 17:49:24 -07:00
ea035471ce
online defrag notifies gRPC health server to expose NOT_SERVING status
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-25 08:58:33 -07:00
aea1cd0077
feat: enable unparam lint
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-10-17 21:24:13 +08:00
7a57e06eca
etcdserver: add livez and ready http endpoints for etcd.
...
Add two separate probes, one for liveness and one for readiness. The liveness probe would check that the local individual node is up and running, or else restart the node, while the readiness probe would check that the cluster is ready to serve traffic. This would make etcd health-check fully Kubernetes API complient.
Signed-off-by: Siyuan Zhang <sizhang@google.com >
2023-10-14 22:32:16 -07:00
867faa1924
etcdserver: remove redundant len check in health check
...
From the Go specification [1]:
"1. For a nil slice, the number of iterations is 0."
`len` returns 0 if the slice or map is nil [2]. Therefore, checking
`len(v) > 0` around a loop is unnecessary.
[1]: https://go.dev/ref/spec#For_range
[2]: https://pkg.go.dev/builtin#len
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2023-10-13 18:39:38 +08:00
c25f1dff82
http health check bug fixes
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-10-12 16:59:34 -07:00
70a3205506
fix broken unit test in server_test.go
...
Signed-off-by: Geeta Gharpure <geetagh@amazon.com >
2023-09-28 20:07:06 +01:00
9c9804399e
do not update RaftCluster.members and RaftCluster.removed if the v3store is ahead of the current replayed WAL entry index
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-28 20:06:12 +01:00
4704a5af3a
*: fix unused issue
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-25 19:37:18 +08:00
896d161d16
*: fix stylecheck linter
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-25 19:14:01 +08:00
07effc4d0a
*: fix revive linter
...
Remove old revive_pass in the bash scripts and migirate the revive.toml
into golangci linter_settings.
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-24 14:21:11 +08:00
aa97484166
*: enable goimports in verify-lint
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-21 21:14:09 +08:00
5e3910d96c
*: fix govet-shadow lint
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-19 20:24:01 +08:00
189f709a5d
Apply patches on the generated *.pb.gw.go files to convert v1 messages to v2 messages
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-18 11:22:16 +01:00
4ec581a6a3
re-generate all the *.pb.gw.go files
...
Run ./scripts/genproto.sh
Signed-off-by: Benjamin Wang <wachao@vmware.com >
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-09-18 11:22:15 +01:00
522b698928
upgrade grpc-gateway from v1 to v2
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-09-18 11:22:15 +01:00
c0aa3b613b
Use any instead of interface{}
...
Signed-off-by: chenyahui <cyhone@qq.com >
2023-09-17 17:41:58 +08:00
f432c1cf20
chore: pkg import more than once
...
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com >
2023-08-21 10:19:05 +08:00
10c7e81cac
Merge pull request #16358 from ahrtr/remove_creds_bundle_20230802
...
clientv3: remove the experimental gRPC API grpccredentials.Bundle
2023-08-04 08:46:02 +01:00
979102f895
clientv3: remove the experimental gRPC API grpccredentials.Bundle
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2023-08-02 19:35:51 +01:00
e5b7dde17e
Add a method to export membership info to v2 store from RaftCluster
...
Signed-off-by: Geeta Gharpure <geetagh@amazon.com >
2023-07-28 16:55:41 +00:00
abbfc2964a
Fix goword issue
...
Fix `make verify` issues after updating golangci-lint
Signed-off-by: iuriatan <iuriatan@gmail.com >
2023-07-14 16:46:26 -03:00
eff9517a90
etcdserver: add cluster id check for hashKVHandler
...
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com >
2023-07-05 14:09:40 -05:00
e9fa3d30d7
Enable test to verify membership recovery from backend
...
Signed-off-by: Geeta Gharpure <geetagh@amazon.com >
2023-06-13 18:33:03 +00:00
0c919dc212
use the more efficient strings.Builder
...
Signed-off-by: cui fliter <imcusg@gmail.com >
2023-05-19 10:44:58 +08:00
1ba577e499
server/etcdserver: togRPCError for maintenance API
...
It's to deflake TestAuthMemberRemove.
When the client has multiple endpoints, the client might send a request
with valid token to the follower member which hasn't received token
replicated log yet. The member will reject the request.
For instance, the maintenance.Status API will return "auth: invalid auth
token". But the client doesn't identify the error. The client won't retry to
refresh auth token. The maintenance.Status should togRPCError before return
so that the client can reflesh token. It's align with existing API.
Since the maintenance client always creates one connection to target
member, the member will have the token after refresh auth.
Maybe we can introduce a sync to wait for member is ready with token,
instead of refreshing.
Fixes : #15758
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2023-04-22 18:35:53 +08:00
